Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message aggregator should prepare a string dictionary and send that as a message over to the client #120

Open
emilsoman opened this issue May 31, 2015 · 1 comment

Comments

@emilsoman
Copy link
Contributor

Whenever strings are encountered, we should put that into a dictionary, basically a hash that looks like :

{ 1 => 'MyClass', 2 => 'my_method', 3 => 'String' }

This could be sent to the client when a message batch is dispatched. The client will need to keep referring this reconstruct strings in the UI. This is going to bring down our network cost by a lot, I have not measured how much yet.

@emilsoman
Copy link
Contributor Author

I am thinking of adding a separate event type called dictionary or something with the following format :

{
  timestamp: <timestamp in ms>,
  event_type: 'dictionary',
  correlation_id: <id indicating event this message is part of>,
  complete_message_count: <total number of messages this event is split into>
  payload: {
    <unsigned long number>: <string>,
    ...
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant