Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user input validation in ImageController.php #59

Closed
kmille opened this issue Feb 2, 2022 · 1 comment
Closed

user input validation in ImageController.php #59

kmille opened this issue Feb 2, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@kmille
Copy link

kmille commented Feb 2, 2022

Hey,
in src/controllers/ImageController.php, you read from a file with unsanitized user input. Even if it's not super exploitable as you append static strings I would prefere some user input validation. You can copy/paste from the docs:
https://docs.craftcms.com/api/v3/craft-web-response.html#method-sendfile
I hope we left the time where you can send null bytes to php with %00.

@kmille kmille added the enhancement New feature or request label Feb 2, 2022
@kringkaste
Copy link
Member

Hey, we just released version 2.0 with changed input validation. Thanks for the hint!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants