Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Guava dependency from 16.x to 21.x #18

Merged
merged 1 commit into from
May 20, 2017
Merged

Updating Guava dependency from 16.x to 21.x #18

merged 1 commit into from
May 20, 2017

Conversation

apolaskey
Copy link
Contributor

All 40 tests passed; installed locally and ran with project and report was successfully generated with a backing Guava dependency of 21

@apolaskey
Copy link
Contributor Author

Should note also bumped up minor due to the huge jump in the guava dep.

@kunal546 kunal546 merged commit a1f0d6a into codepine:master May 20, 2017
@kunal546
Copy link
Contributor

I approved this but found out that Guava 21 needs JDK 8 and this project is still using 7.

https://github.com/google/guava/wiki/Release21

Can you please test building this with 1.7 and running it from an application with 1.7 runtime? We may need to upgrade the jdk.version to 1.7.

@apolaskey
Copy link
Contributor Author

@kunal546 Just to be clear your asking for a PR with the plugins updated for JDK8?

@apolaskey
Copy link
Contributor Author

@kunal546 Two routes we can take here; update the Maven target to 1.8 or downgrade to Guava 20.0 to preserve JDK7 compat.

For now I'll submit a PR to master for the POM updates to target JDK8; what's strange is that it built fine with the 1.7 target (could be that what's used from Guava isn't requiring it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants