Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run extensions in production mode #4219

Closed
jsjoeio opened this issue Sep 21, 2021 · 6 comments
Closed

Run extensions in production mode #4219

jsjoeio opened this issue Sep 21, 2021 · 6 comments
Labels
bug Something isn't working high-priority This issue needs to be resolved ASAP
Milestone
4.0.1

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 21, 2021 •
edited
Loading

ExtensionContext.extensionMode (passed to activate) is set to ExtensionMode.Development (integer value of 2) instead of Production. In other words, code-server runs extensions in non-production mode, which my extension took as a sign to enable that devserver shortcut. Not really a problem, if it weren't for the next problem

@SchoofsKelvin

Originally posted: #4075 (reply in thread)

Related: SchoofsKelvin/vscode-sshfs#279
@jsjoeio jsjoeio added the bug Something isn't working label Sep 21, 2021
@jsjoeio jsjoeio added this to the On Deck milestone Sep 21, 2021
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Sep 21, 2021

cc @TeffenEllis (I figured you would find this interesting! Probably something we did a long time ago if I had to guess?)

@benz0li
Copy link
Contributor

benz0li commented Sep 28, 2021

Related: REditorSupport/vscode-R#275 (comment)

@jsjoeio jsjoeio added the high-priority This issue needs to be resolved ASAP label Sep 29, 2021
@tianjianchnbytedance
Copy link

@jsjoeio So may I ask you that why did we set the extensionMode to development?

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Oct 28, 2021

@tianjianchnbytedance I wish I could tell you - that's before my time! Probably a goof on our end when adding our VS Code fork to code-server. Should be an easy fix though.

@benz0li
Copy link
Contributor

benz0li commented Dec 11, 2021

This issue seems to be resolved with v4.0.0.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 13, 2021

Woohoo! Thank you for confirming @benz0li

I'll close this for now then.

@jsjoeio jsjoeio closed this as completed Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working high-priority This issue needs to be resolved ASAP
Projects
None yet
Milestone
4.0.1
Development

No branches or pull requests
3 participants
@jsjoeio @benz0li @tianjianchnbytedance