New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract display language patch and submit PR upstream #4703

Closed

jsjoeio opened this issue Jan 7, 2022 · 1 comment

Assignees

Labels

feature

Milestone

Contributor

jsjoeio commented Jan 7, 2022

@code-asher recently patched #4598 in coder/vscode#34 (which we've had for a while but lost in a vscode upgrade).

We noticed this issue exists upstream in Codespaces, VS Code Web and have discussed extracting our patch and submitting a PR upstream.

The extraction will require some tweaking, but hoping it's not too difficult.

Related

jsjoeio added the feature label

jsjoeio added this to the 4.0.2 milestone

jsjoeio self-assigned this

code-asher modified the milestones: 4.0.2, 4.0.3

jsjoeio modified the milestones: 4.0.3, On Deck

jsjoeio modified the milestones: On Deck, March 2022

jsjoeio modified the milestones: March 2022, April 2022

jsjoeio mentioned this issue

feat(web): add support for language packs microsoft/vscode#146012

Closed

jsjoeio modified the milestones: April 2022, May 2022

Contributor Author

jsjoeio commented Jun 15, 2022

They ended up going with a different approach. See microsoft/vscode#146012 (comment)

jsjoeio closed this as not planned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment