Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coder Terraform Provider v1.0 Docs #217

Closed
29 tasks done
stirby opened this issue Apr 29, 2024 · 9 comments · Fixed by #249 or #254
Closed
29 tasks done

Coder Terraform Provider v1.0 Docs #217

stirby opened this issue Apr 29, 2024 · 9 comments · Fixed by #249 or #254
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@stirby
Copy link
Contributor

stirby commented Apr 29, 2024

Customers have requested that we promote our terraform provider to v1.0. The product is quite stable and, of course, is used in every one of our customers' deployments.

To show that this is no longer breaking, we should promote the release versioning to v1.X.X; before we do so, the docs should meet v1.0 standards. As I mentioned, we don't get many stability requests, but there are often requests for elaboration on the provider's behavior. There are a few resources/data sources that are missing code examples, or may be enriched via context.

Docs checklist for v1.0

@stirby stirby added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 29, 2024
@stirby
Copy link
Contributor Author

stirby commented May 2, 2024

A candidate to further improve the docs here:
coder/coder#13122

@matifali
Copy link
Member

matifali commented May 2, 2024

Yes we should mention the minimum required coder version on the main page of provider docs for each release.

For example when we publish version 1.0.3 of the provider, we should mention as a warning block on main page that

Important

This provider version requires Coder version 2.11.0 or above.

Or we can move the warning to only the resources that are affected.

Like for coder_env page we can include.

Important

This provider version requires Coder version 2.7.0 or above.

@matifali
Copy link
Member

matifali commented May 6, 2024

Before realizing 1.0, we should do migration #180. Otherwise, it will stay a debt.

@bpmct
Copy link
Member

bpmct commented May 6, 2024

coder/envbuilder#174 (comment) a good idea to add a new coder_user data source and deprecate the owner_ stuff

@matifali
Copy link
Member

matifali commented May 6, 2024

coder/envbuilder#174 (comment) a good idea to add a new coder_user data source and deprecate the owner_ stuff

@bpmct filed #219 and #220

@stirby
Copy link
Contributor Author

stirby commented May 8, 2024

Before realizing 1.0, we should do migration #180. Otherwise, it will stay a debt.

@matifali I understand the motivation here, but do not want to block v1.0 for the migration. I would even call this a candidate for v2.0. I'd rather rush these documentation changes + any minor changes and promote the versioning for the comfort of our customers.

If this unblocks feature development today, we can discuss.

For posterity

We recommend using the framework to develop new provider functionality because it offers significant advantages as compared to the SDKv2. We also recommend migrating existing providers to the framework when possible.

@matifali
Copy link
Member

matifali commented May 9, 2024

@stirby Sure, let's do that in v2.0, then.

@stirby
Copy link
Contributor Author

stirby commented Jul 1, 2024

I am re-opening since we need to cut the v1.0

@stirby stirby reopened this Jul 1, 2024
@matifali
Copy link
Member

matifali commented Jul 1, 2024

@stirby I think we should resolve #203 too before we cut the 1.0 release.

It doesn't matter if we are removing all deprecated items. But that needs to be done too #250.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
4 participants