Use cli version for featureset detection #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
approved these changes
Jul 26, 2024
Member
code-asher
left a comment
code-asher
left a comment
There was a problem hiding this comment.
Looks perfect!
when I go to test this the proxyLogDirectory setting doesn't show up in my extension settings, I must be doing something silly.
Weird, I tested and it worked for me at least. Maybe it needed to be rebuilt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a
FeatureSetobject describing the features supported by a given coder version. It also changes the logic to use the CLI version if available (failing that we use the version from buildinfo like before).closes #323
@code-asher when I go to test this the proxyLogDirectory setting doesn't show up in my extension settings, I must be doing something silly.