4
4
5
5
Please be as descriptive as possible with your description.
6
6
7
+ Reproducible examples are key to fixing bugs and strongly encouraged.
8
+
7
9
## Pull requests
8
10
9
- Please split up changes into several small descriptive commits.
11
+ Good issues for first time contributors are marked as such. Please feel free to
12
+ reach out for clarification on what needs to be done.
13
+
14
+ Split up large changes into several small descriptive commits.
10
15
11
- Please capitalize the first word in the commit message title.
16
+ Capitalize the first word in the commit message title.
12
17
13
18
The commit message title should use the verb tense + phrase that completes the blank in
14
19
15
20
> This change modifies websocket to \_\_\_\_\_\_\_\_\_
16
21
17
- Be sure to link to an existing issue if one exists. In general, try creating an issue
18
- before making a PR to get some discussion going and to make sure you do not spend time
22
+ Be sure to link to an existing issue if one exists. In general, create an issue
23
+ before a PR to get some discussion going and to make sure you do not spend time
19
24
on a PR that may be rejected.
20
25
21
26
You can run tests normally with ` go test ` .
@@ -25,10 +30,10 @@ In the future this dependency will be removed. See [#117](https://github.com/nho
25
30
Please ensure CI passes for your changes. If necessary, you may run CI locally.
26
31
The various steps are located in ` ci/*.sh ` .
27
32
28
- ` ci/fmt.sh ` requires node (specifically prettier).
29
- ` ci/lint.sh ` requires [ shellcheck] ( https://github.com/koalaman/shellcheck#installing ) .
30
- ` ci/test.sh ` requires the [ Autobahn Test suite pip package] ( https://github.com/crossbario/autobahn-testsuite ) .
31
- ` ci/run.sh ` runs everything in the above order and requires all of their dependencies.
33
+ - ` ci/fmt.sh ` requires node (specifically prettier).
34
+ - ` ci/lint.sh ` requires [ shellcheck] ( https://github.com/koalaman/shellcheck#installing ) .
35
+ - ` ci/test.sh ` requires the [ Autobahn Test suite pip package] ( https://github.com/crossbario/autobahn-testsuite ) .
36
+ - ` ci/run.sh ` runs everything in the above order and requires all of their dependencies.
32
37
33
38
See [ ../ci/image/Dockerfile] ( ../ci/image/Dockerfile ) for the installation of the CI dependencies on Ubuntu.
34
39
0 commit comments