Skip to content

Commit 2140b19

Browse files
authored
Merge pull request #120 from nhooyr/docs
Make CONTRIBUTING.md more visible
2 parents 49a2832 + 853d3f0 commit 2140b19

File tree

4 files changed

+21
-8
lines changed

4 files changed

+21
-8
lines changed

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,10 @@ If you want a library that gives you absolute control over everything, this is t
158158
but for most users, the API provided by nhooyr/websocket will fit better as it is nearly just
159159
as performant but much easier to use correctly and idiomatic.
160160

161+
## Contributing
162+
163+
Please see [docs/CONTRIBUTING.md](docs/CONTRIBUTING.md).
164+
161165
## Users
162166

163167
This is a list of companies or projects that use this library.

docs/CONTRIBUTING.md

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,23 @@
44

55
Please be as descriptive as possible with your description.
66

7+
Reproducible examples are key to fixing bugs and strongly encouraged.
8+
79
## Pull requests
810

9-
Please split up changes into several small descriptive commits.
11+
Good issues for first time contributors are marked as such. Please feel free to
12+
reach out for clarification on what needs to be done.
13+
14+
Split up large changes into several small descriptive commits.
1015

11-
Please capitalize the first word in the commit message title.
16+
Capitalize the first word in the commit message title.
1217

1318
The commit message title should use the verb tense + phrase that completes the blank in
1419

1520
> This change modifies websocket to \_\_\_\_\_\_\_\_\_
1621
17-
Be sure to link to an existing issue if one exists. In general, try creating an issue
18-
before making a PR to get some discussion going and to make sure you do not spend time
22+
Be sure to link to an existing issue if one exists. In general, create an issue
23+
before a PR to get some discussion going and to make sure you do not spend time
1924
on a PR that may be rejected.
2025

2126
You can run tests normally with `go test`.
@@ -25,10 +30,10 @@ In the future this dependency will be removed. See [#117](https://github.com/nho
2530
Please ensure CI passes for your changes. If necessary, you may run CI locally.
2631
The various steps are located in `ci/*.sh`.
2732

28-
`ci/fmt.sh` requires node (specifically prettier).
29-
`ci/lint.sh` requires [shellcheck](https://github.com/koalaman/shellcheck#installing).
30-
`ci/test.sh` requires the [Autobahn Test suite pip package](https://github.com/crossbario/autobahn-testsuite).
31-
`ci/run.sh` runs everything in the above order and requires all of their dependencies.
33+
- `ci/fmt.sh` requires node (specifically prettier).
34+
- `ci/lint.sh` requires [shellcheck](https://github.com/koalaman/shellcheck#installing).
35+
- `ci/test.sh` requires the [Autobahn Test suite pip package](https://github.com/crossbario/autobahn-testsuite).
36+
- `ci/run.sh` runs everything in the above order and requires all of their dependencies.
3237

3338
See [../ci/image/Dockerfile](../ci/image/Dockerfile) for the installation of the CI dependencies on Ubuntu.
3439

docs/ISSUE_TEMPLATE.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
<!-- Please read the contributing guidelines. -->
2+
<!-- https://github.com/nhooyr/websocket/blob/master/docs/CONTRIBUTING.md#pull-requests -->

docs/PULL_REQUEST_TEMPLATE.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
<!-- Please read the contributing guidelines. -->
2+
<!-- https://github.com/nhooyr/websocket/blob/master/docs/CONTRIBUTING.md#issues -->

0 commit comments

Comments
 (0)