Skip to content

Add detailed design doc with links and justifications #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nhooyr opened this issue Apr 12, 2019 · 4 comments
Closed

Add detailed design doc with links and justifications #51

nhooyr opened this issue Apr 12, 2019 · 4 comments
Labels
docs
Milestone
v0.2.0

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Apr 12, 2019

E.g. why functional options over options structure, why things work the way they do, the different trade offs I made.

See also google/go-cloud#908
@nhooyr nhooyr added this to the v0.2.0 milestone Apr 12, 2019
@nhooyr
Copy link
Contributor Author

nhooyr commented Apr 15, 2019

See #54

@nhooyr
Copy link
Contributor Author

nhooyr commented Apr 15, 2019

Going with functional options over a config struct because I want the default case to be as simple and brief as possible.

@nhooyr
Copy link
Contributor Author

nhooyr commented Apr 21, 2019

This is definitely something I should do after I release the library.

@nhooyr
Copy link
Contributor Author

nhooyr commented Apr 25, 2019

Not really necessary.

@nhooyr nhooyr closed this as completed Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
1 participant
@nhooyr