Skip to content

Commit 6a7d64e

Browse files
yzhu1Jeff Kirsher
authored andcommitted
e1000: prevent oops when adapter is being closed and reset simultaneously
This change is based on a similar change made to e1000e support in commit bb9e44d ("e1000e: prevent oops when adapter is being closed and reset simultaneously"). The same issue has also been observed on the older e1000 cards. Here, we have increased the RESET_COUNT value to 50 because there are too many accesses to e1000 nic on stress tests to e1000 nic, it is not enough to set RESET_COUT 25. Experimentation has shown that it is enough to set RESET_COUNT 50. Signed-off-by: yzhu1 <yanjun.zhu@windriver.com> Tested-by: Aaron Brown <aaron.f.brown@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
1 parent 42ce412 commit 6a7d64e

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

drivers/net/ethernet/intel/e1000/e1000.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,11 @@ struct e1000_adapter;
8383

8484
#define E1000_MAX_INTR 10
8585

86+
/*
87+
* Count for polling __E1000_RESET condition every 10-20msec.
88+
*/
89+
#define E1000_CHECK_RESET_COUNT 50
90+
8691
/* TX/RX descriptor defines */
8792
#define E1000_DEFAULT_TXD 256
8893
#define E1000_MAX_TXD 256

drivers/net/ethernet/intel/e1000/e1000_main.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1440,6 +1440,10 @@ static int e1000_close(struct net_device *netdev)
14401440
{
14411441
struct e1000_adapter *adapter = netdev_priv(netdev);
14421442
struct e1000_hw *hw = &adapter->hw;
1443+
int count = E1000_CHECK_RESET_COUNT;
1444+
1445+
while (test_bit(__E1000_RESETTING, &adapter->flags) && count--)
1446+
usleep_range(10000, 20000);
14431447

14441448
WARN_ON(test_bit(__E1000_RESETTING, &adapter->flags));
14451449
e1000_down(adapter);
@@ -4963,6 +4967,11 @@ static int __e1000_shutdown(struct pci_dev *pdev, bool *enable_wake)
49634967
netif_device_detach(netdev);
49644968

49654969
if (netif_running(netdev)) {
4970+
int count = E1000_CHECK_RESET_COUNT;
4971+
4972+
while (test_bit(__E1000_RESETTING, &adapter->flags) && count--)
4973+
usleep_range(10000, 20000);
4974+
49664975
WARN_ON(test_bit(__E1000_RESETTING, &adapter->flags));
49674976
e1000_down(adapter);
49684977
}

0 commit comments

Comments
 (0)