Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleMultisig: style suggestion: remove require collation #11

Closed
veox opened this issue Nov 11, 2017 · 1 comment
Closed

SimpleMultisig: style suggestion: remove require collation #11

veox opened this issue Nov 11, 2017 · 1 comment

Comments

@veox
Copy link

veox commented Nov 11, 2017

This line, but also others:

require(owners_.length <= 10 && threshold_ <= owners_.length && threshold_ != 0);

... collates several checks into one, which IMO is a bad practice (the expressions eventually grow too complex); and, more importantly, will hinder providing a useful failure message when that becomes available.

@coder5876
Copy link
Owner

Hmm, I don't really agree that this is too complex, it's a fairly simple expression IMO. I'm not too worried about error messages, app developers should replicate these checks in their frontend code to catch errors before going to the smart contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants