-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Closed
coderabbit-test/bazel
#4Closed
Copy link
Labels
P3We're not considering working on this, but happy to review a PR. (No assignee)We're not considering working on this, but happy to review a PR. (No assignee)team-Rules-CPPIssues for C++ rulesIssues for C++ rulestype: feature request
Description
Currently, includes
is misleading, since the name does not in any way reflect the fact that the headers will be included as system headers. This goes against developer expectations.
System headers should rarely be used on own code, because all C++ tools (compilers, static analyzers, etc) will ignore warnings in such headers.
It would be a lot clearer and easy to spot during code review if includes
was renamed to system_includes
.
fmeum, martis42, armandomontanez and jungleraptor
Metadata
Metadata
Assignees
Labels
P3We're not considering working on this, but happy to review a PR. (No assignee)We're not considering working on this, but happy to review a PR. (No assignee)team-Rules-CPPIssues for C++ rulesIssues for C++ rulestype: feature request