Skip to content

Request: rename includes to system_includes in cc_* functions #20267

Open
coderabbit-test/bazel
#4
@carlosgalvezp

Description

@carlosgalvezp

Currently, includes is misleading, since the name does not in any way reflect the fact that the headers will be included as system headers. This goes against developer expectations.

System headers should rarely be used on own code, because all C++ tools (compilers, static analyzers, etc) will ignore warnings in such headers.

It would be a lot clearer and easy to spot during code review if includes was renamed to system_includes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3We're not considering working on this, but happy to review a PR. (No assignee)team-Rules-CPPIssues for C++ rulestype: feature request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions