Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt type #23

Open
ray73864 opened this issue Feb 3, 2020 · 5 comments
Open

Prompt type #23

ray73864 opened this issue Feb 3, 2020 · 5 comments

Comments

@ray73864
Copy link

ray73864 commented Feb 3, 2020

Currently the prompt only supports a type of 'password', is it possible to get this changed so that it can support any valid input type?

I currently have need for it to be 'type="number"' as the HTML page this is on is being viewed on a mobile device and I want the on-screen keyboard to only show up as a numeric keyboard.

@coderaiser
Copy link
Owner

That's amazing idea for a pull request :)

@ray73864
Copy link
Author

ray73864 commented Feb 4, 2020

I have no idea how to do that :(

I cloned the repository, ran 'npm install' on it, but when I do 'npm run build' it comes up with issues :(

root@web-debian:/var/www/assets/dist/source/smalltalk# npm run build

> smalltalk@4.0.2 build /var/www/assets/dist/source/smalltalk
> madrun build

/var/www/assets/dist/source/smalltalk/node_modules/find-up/index.js:8
module.exports = async (name, options = {}) => {
                       ^
SyntaxError: Unexpected token (
    at Object.exports.runInThisContext (vm.js:78:16)
    at Module._compile (module.js:543:28)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/var/www/assets/dist/source/smalltalk/node_modules/madrun/bin/madrun.js:7:16)
    at Module._compile (module.js:571:32)

npm ERR! Linux 4.19.0-6-amd64
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "build"
npm ERR! node v7.4.0
npm ERR! npm  v4.0.5
npm ERR! code ELIFECYCLE
npm ERR! smalltalk@4.0.2 build: `madrun build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the smalltalk@4.0.2 build script 'madrun build'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the smalltalk package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     madrun build
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs smalltalk
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls smalltalk
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /var/www/assets/dist/source/smalltalk/npm-debug.log

@coderaiser
Copy link
Owner

Please update to your node version to v12, v7 is very old and deprecated :).

@ray73864
Copy link
Author

ray73864 commented Feb 4, 2020

I feel stupid now :)

Doing things with node.js is not my norm, but upgrading Node to v12 made it all work.

Now I can figure out a decent way to do this change and work out how to do a PR (not something I normally do either).

Waaay out of my comfort zone right now :P

@coderaiser
Copy link
Owner

coderaiser commented Feb 5, 2020

Doing things with node.js is not my norm, but upgrading Node to v12 made it all work.

The thing is async-await functions made available in LTS since node 8 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants