Use correct site when loading settings #341
Labels
Area: Multisite 🏨
Type: Tech Debt
Use this label for decisions that will intentionally require refactor in the future.
When loading wagtail settings, such as
GoogleApiSettings
orMailchimpApiSettings
we have a tendency to do these in a place where noSite
is available and explicitly load the default site. This is a bad practice as it totally breaks the concept of multi-site.This practice needs to be refactored to get the site from the page or request, and if those are not available, use dependency injection techniques.
The text was updated successfully, but these errors were encountered: