Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct site when loading settings #341

Open
vsalvino opened this issue Aug 2, 2020 · 0 comments
Open

Use correct site when loading settings #341

vsalvino opened this issue Aug 2, 2020 · 0 comments
Labels
Area: Multisite 🏨 Type: Tech Debt Use this label for decisions that will intentionally require refactor in the future.

Comments

@vsalvino
Copy link
Contributor

vsalvino commented Aug 2, 2020

When loading wagtail settings, such as GoogleApiSettings or MailchimpApiSettings we have a tendency to do these in a place where no Site is available and explicitly load the default site. This is a bad practice as it totally breaks the concept of multi-site.

This practice needs to be refactored to get the site from the page or request, and if those are not available, use dependency injection techniques.

@vsalvino vsalvino added Type: Tech Debt Use this label for decisions that will intentionally require refactor in the future. Area: Multisite 🏨 labels Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Multisite 🏨 Type: Tech Debt Use this label for decisions that will intentionally require refactor in the future.
Projects
None yet
Development

No branches or pull requests

1 participant