Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict app to only portrait screen mode #26

Open
wahibhaq opened this issue Feb 14, 2018 · 3 comments
Open

Restrict app to only portrait screen mode #26

wahibhaq opened this issue Feb 14, 2018 · 3 comments
Assignees
Labels

Comments

@wahibhaq
Copy link
Collaborator

wahibhaq commented Feb 14, 2018

I would strongly suggest to make app only support portrait because of 2 reasons.

  1. I don't see much use with landscape mode. This is a typical content (mostly lists based screen) heavy app which works perfectly with portrait mode
  2. We can save ourselves from a lot of problems related to retaining state when screen is rotated. State Management in Android is not an easy thing. There are solutions possible of course but always adds an additional overhead. Considering our situation its efficient to reduce potential problems.

P.S: Currently app crashes on Services tab and you try to move from portrait -> landscape -> come back to portrait which is caused by NullPointerException in MainActivity:122. We should definitely fix this problem but also disable landscape mode.

I can handle it or even shahzaib can handle it. not a big deal!

@wahibhaq wahibhaq self-assigned this Feb 14, 2018
@wahibhaq wahibhaq added the bug label Feb 14, 2018
@codernaut
Copy link
Owner

removing enhancement because making it both bug and enhancement is oxymoron

@codernaut
Copy link
Owner

and i agree its so simple that even a noob like me can do it so I will do it :D

@wahibhaq
Copy link
Collaborator Author

ok then :)

@wahibhaq wahibhaq assigned codernaut and unassigned wahibhaq Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants