Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unused dependencies and deleting unused dummy classes #8

Open
wahibhaq opened this issue Jan 17, 2018 · 0 comments
Open

Removing unused dependencies and deleting unused dummy classes #8

wahibhaq opened this issue Jan 17, 2018 · 0 comments

Comments

@wahibhaq
Copy link
Collaborator

wahibhaq commented Jan 17, 2018 •
edited
Loading

  1. I can see that RxJava dependency is included in gradle compile 'io.reactivex:rxjava:1.1.0' but only referred in the 3 classes in io.reactivex package which is also then not used. Removing unused code is always better. Also I would highly recommend to use it when needed but RxJava2 instead of RxJava1 which is already obsolete.

  2. Picasso dependency is also unused if I am not wrong.
@wahibhaq wahibhaq changed the title Removing unused RxJava dependency and deleting unused classes Removing unused RxJava dependency and deleting unused dummy classes Jan 17, 2018
@wahibhaq wahibhaq changed the title Removing unused RxJava dependency and deleting unused dummy classes Removing unused dependencies and deleting unused dummy classes Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wahibhaq