Skip to content

Fix extension build #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcandan opened this issue Feb 2, 2025 · 3 comments
Closed

Fix extension build #628

jcandan opened this issue Feb 2, 2025 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jcandan
Copy link

jcandan commented Feb 2, 2025

Is your feature request related to a problem? Please describe.

Cloning the repo and running npm install fails with ERESOLVE unable to resolve dependency tree.

Needed to downgrade to Node 12 and Node 16 to run.

Describe the solution you'd like

Support Node 18 at least. But, if performing the upgrade, it would make sense to support the latest LTS version 22.

@jcandan jcandan added the enhancement New feature or request label Feb 2, 2025
@jcandan
Copy link
Author

jcandan commented Feb 2, 2025

My bad. Needed to be using Yarn. Yarn build requires Node 16 or higher. Will test and report back.

@jcandan
Copy link
Author

jcandan commented Feb 2, 2025

Okay, tried Node 16 and Node 18 with rm -rf node_modules/ web-app/node_modules/ && yarn --cwd web-app cache clean && yarn cache clean && yarn install-all && yarn build.

Could not get around the following:

Building webapp...
$ react-app-rewired build

There might be a problem with the project dependency tree.
It is likely not a bug in Create React App, but something you need to fix locally.

The react-scripts package provided by Create React App requires a dependency:

  "babel-loader": "8.1.0"

Don't try to install it manually: your package manager does it automatically.
However, a different version of babel-loader was detected higher up in the tree:

  /path/to/coderoad-vscode/web-app/node_modules/babel-loader (version: 8.2.2)

Seems react-scripts has a dependency on babel-loader 8.1.0, while the web-app depends on 8.2.2.

Tried various upgrade attempts, and ran into all manner of issues running the build.

This ticket title probably needs a change.

@jcandan jcandan changed the title Update extension development to Node 18 minimum Fix extension build Feb 2, 2025
@jcandan
Copy link
Author

jcandan commented Feb 2, 2025

When CONTRIBUTING.md didn't offer direction, I didn't think to check the docs.

Found https://coderoad.github.io/docs/development/.

Fixed my build with the .env file, because it sets to SKIP_PREFLIGHT_CHECK.

@jcandan jcandan closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants