refactor(editor-validator): more spec on invalid schema opt error hint

Author: mydearxym

lib/helper/validator/schema.ex

@@ -56,13 +56,16 @@ defmodule Helper.Validator.Schema do
     end)
   end
 
-  defp option_valid?({:min, v}) when is_integer(v), do: true
-  defp option_valid?({:required, v}) when is_boolean(v), do: true
-  defp option_valid?({:starts_with, v}) when is_binary(v), do: true
-  defp option_valid?({:type, :map}), do: true
-  defp option_valid?({:allow_empty, v}) when is_boolean(v), do: true
+  defp option_valid?(:string, {:min, v}) when is_integer(v), do: true
+  defp option_valid?(:number, {:min, v}) when is_integer(v), do: true
 
-  defp option_valid?(_), do: false
+  defp option_valid?(_, {:required, v}) when is_boolean(v), do: true
+  defp option_valid?(:string, {:starts_with, v}) when is_binary(v), do: true
+  defp option_valid?(:list, {:type, :map}), do: true
+  defp option_valid?(:string, {:allow_empty, v}) when is_boolean(v), do: true
+  defp option_valid?(:list, {:allow_empty, v}) when is_boolean(v), do: true
+
+  defp option_valid?(_, _), do: false
 
   defp match(field, nil, enum: _, required: false), do: done(field, nil)
   defp match(field, value, enum: enum, required: _), do: match(field, value, enum: enum)
@@ -149,7 +152,7 @@ defmodule Helper.Validator.Schema do
   # error for option
   defp match(field, value, type, [option]) when is_tuple(option) do
     # 如果这里不判断的话会和下面的 match 冲突，是否有更好的写法？
-    case option_valid?(option) do
+    case option_valid?(type, option) do
       true ->
         error(field, value, type)
 

test/helper/validator/schema_test.exs

@@ -15,7 +15,7 @@ defmodule GroupherServer.Test.Helper.Validator.Schema do
       schema = %{"text" => [:string, required: true]}
       data = %{"no_exsit" => "text"}
       {:error, error} = Schema.cast(schema, data)
-      assert error == [%{field: "text", message: "should be: string", value: nil}]
+      assert [%{field: "text", message: "should be: string", value: nil}] == error
 
       schema = %{"text" => [:string, required: true]}
       data = %{"text" => "text"}
@@ -24,32 +24,32 @@ defmodule GroupherServer.Test.Helper.Validator.Schema do
       schema = %{"text" => [:string, min: 5]}
       data = %{"text" => "text"}
       {:error, error} = Schema.cast(schema, data)
-      assert error == [%{field: "text", message: "min size: 5", value: "text"}]
+      assert [%{field: "text", message: "min size: 5", value: "text"}] == error
 
       schema = %{"text" => [:string, required: false, min: 5]}
       data = %{"text" => "text"}
       {:error, error} = Schema.cast(schema, data)
-      assert error == [%{field: "text", message: "min size: 5", value: "text"}]
+      assert [%{field: "text", message: "min size: 5", value: "text"}] === error
 
       schema = %{"text" => [:string, min: 5]}
       data = %{"no_exsit" => "text"}
       {:error, error} = Schema.cast(schema, data)
-      assert error == [%{field: "text", message: "should be: string", value: nil}]
+      assert [%{field: "text", message: "should be: string", value: nil}] == error
 
       schema = %{"text" => [:string, required: true, min: 5]}
       data = %{"no_exsit" => "text"}
       {:error, error} = Schema.cast(schema, data)
-      assert error == [%{field: "text", message: "should be: string", value: nil}]
+      assert [%{field: "text", message: "should be: string", value: nil}] == error
 
       schema = %{"text" => [:string, required: true, min: "5"]}
       data = %{"text" => "text"}
       {:error, error} = Schema.cast(schema, data)
-      assert error == [%{field: "text", message: "unknow option: min: 5", value: "text"}]
+      assert [%{field: "text", message: "unknow option: min: 5", value: "text"}] == error
 
       schema = %{"text" => [:string, starts_with: "https://"]}
       data = %{"text" => "text"}
       assert {:error, error} = Schema.cast(schema, data)
-      assert error == [%{field: "text", message: "should starts with: https://", value: "text"}]
+      assert [%{field: "text", message: "should starts with: https://", value: "text"}] == error
 
       schema = %{"text" => [:string, allow_empty: false]}
       data = %{"text" => ""}
@@ -149,8 +149,7 @@ defmodule GroupherServer.Test.Helper.Validator.Schema do
       data = %{"text" => [1, 2, 3]}
       {:error, error} = Schema.cast(schema, data)
 
-      assert error ==
-               [%{field: "text", message: "item should be map", value: [1, 2, 3]}]
+      assert [%{field: "text", message: "item should be map", value: [1, 2, 3]}] == error
 
       schema = %{"text" => [:list, allow_empty: false]}
       data = %{"text" => []}
@@ -169,7 +168,7 @@ defmodule GroupherServer.Test.Helper.Validator.Schema do
       schema = %{"text" => [:boolean, required: true]}
       data = %{"no_exsit" => false}
       {:error, error} = Schema.cast(schema, data)
-      assert error == [%{field: "text", message: "should be: boolean", value: nil}]
+      assert [%{field: "text", message: "should be: boolean", value: nil}] == error
 
       schema = %{"text" => [:boolean, required: true]}
       data = %{"text" => false}
@@ -185,7 +184,7 @@ defmodule GroupherServer.Test.Helper.Validator.Schema do
       schema = %{"text" => [enum: [1, 2, 3], required: true]}
       data = %{"no_exsit" => false}
       {:error, error} = Schema.cast(schema, data)
-      assert error == [%{field: "text", message: "should be: 1 | 2 | 3"}]
+      assert [%{field: "text", message: "should be: 1 | 2 | 3"}] == error
 
       schema = %{"text" => [enum: [1, 2, 3]]}
       data = %{"text" => 1}
@@ -195,14 +194,14 @@ defmodule GroupherServer.Test.Helper.Validator.Schema do
       # hello world
     end
 
-    @tag :wip2
-    test "schema invalid option test" do
-      schema = %{"text" => [:string, allow_empty: false]}
-      data = %{"text" => ""}
-      # assert {:ok, _} = Schema.cast(schema, data)
+    @tag :wip
+    test "schema invalid option should got error" do
+      schema = %{"text" => [:number, allow_empty: false]}
+      data = %{"text" => 1}
+
+      {:error, error} = Schema.cast(schema, data)
 
-      IO.inspect(Schema.cast(schema, data), label: "schema result")
-      #
+      assert [%{field: "text", message: "unknow option: allow_empty: false", value: 1}] == error
     end
   end
 end