chore: length issue

Author: mydearxym

lib/groupher_server/cms/delegates/article_curd.ex

@@ -526,7 +526,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
   defp result({:ok, %{set_viewer_has_states: result}}), do: result |> done()
   defp result({:ok, %{update_article_meta: result}}), do: {:ok, result}
 
-  defp result({:error, :create_article, _result, _steps}) do
+  defp result({:error, :create_article, result, _steps}) do
     {:error, [message: "create article", code: ecode(:create_fails)]}
   end
 

lib/groupher_server/cms/models/blog.ex

@@ -15,12 +15,11 @@ defmodule GroupherServer.CMS.Model.Blog do
 
   @required_fields ~w(title digest)a
   @article_cast_fields general_article_cast_fields()
-  @optional_fields ~w(link_addr digest length)a ++ @article_cast_fields
+  @optional_fields ~w(link_addr digest)a ++ @article_cast_fields
 
   @type t :: %Blog{}
   schema "cms_blogs" do
     field(:link_addr, :string)
-    field(:length, :integer)
 
     article_tags_field(:blog)
     article_communities_field(:blog)

lib/groupher_server/cms/models/job.ex

@@ -12,7 +12,7 @@ defmodule GroupherServer.CMS.Model.Job do
   alias CMS.Model.Embeds
 
   @timestamps_opts [type: :utc_datetime_usec]
-  @required_fields ~w(title company digest length)a
+  @required_fields ~w(title company digest)a
   @article_cast_fields general_article_cast_fields()
   @optional_fields @article_cast_fields ++ ~w(desc company_link link_addr copy_right)a
 
@@ -24,7 +24,6 @@ defmodule GroupherServer.CMS.Model.Job do
 
     field(:link_addr, :string)
     field(:copy_right, :string)
-    field(:length, :integer)
 
     article_tags_field(:job)
     article_communities_field(:job)

lib/groupher_server/cms/models/post.ex

@@ -15,7 +15,7 @@ defmodule GroupherServer.CMS.Model.Post do
 
   @timestamps_opts [type: :utc_datetime_usec]
 
-  @required_fields ~w(title digest length)a
+  @required_fields ~w(title digest)a
   @article_cast_fields general_article_cast_fields()
   @optional_fields ~w(link_addr copy_right is_question is_solved solution_digest)a ++
                      @article_cast_fields
@@ -24,7 +24,6 @@ defmodule GroupherServer.CMS.Model.Post do
   schema "cms_posts" do
     field(:link_addr, :string)
     field(:copy_right, :string)
-    field(:length, :integer)
 
     field(:is_question, :boolean, default: false)
     field(:is_solved, :boolean, default: false)

lib/groupher_server_web/schema/Helper/fields.ex

@@ -168,7 +168,6 @@ defmodule GroupherServerWeb.Schema.Helper.Fields do
   defmacro article_filter_fields do
     quote do
       field(:when, :when_enum)
-      field(:length, :length_enum)
       field(:article_tag, :string)
       field(:article_tags, list_of(:string))
       field(:community, :string)

lib/groupher_server_web/schema/cms/cms_metrics.ex

@@ -161,7 +161,6 @@ defmodule GroupherServerWeb.Schema.CMS.Metrics do
     # field(:sort, :sort_input)
     field(:when, :when_enum)
     field(:sort, :sort_enum)
-    field(:length, :length_enum)
     # @desc "Matching a tag"
     # @desc "Added to the menu after this date"
     # field(:added_after, :datetime)

lib/groupher_server_web/schema/cms/cms_types.ex

@@ -58,7 +58,6 @@ defmodule GroupherServerWeb.Schema.CMS.Types do
     general_article_fields()
     comments_fields()
 
-    field(:length, :integer)
     field(:link_addr, :string)
     field(:copy_right, :string)
 
@@ -74,7 +73,6 @@ defmodule GroupherServerWeb.Schema.CMS.Types do
     field(:desc, :string)
     field(:company, :string)
     field(:company_link, :string)
-    field(:length, :integer)
     field(:link_addr, :string)
     field(:copy_right, :string)
 
@@ -87,7 +85,6 @@ defmodule GroupherServerWeb.Schema.CMS.Types do
     general_article_fields()
     comments_fields()
 
-    field(:length, :integer)
     field(:link_addr, :string)
 
     timestamp_fields(:article)
@@ -99,7 +96,6 @@ defmodule GroupherServerWeb.Schema.CMS.Types do
     general_article_fields()
     comments_fields()
 
-    field(:length, :integer)
     field(:link_addr, :string)
 
     timestamp_fields(:article)
@@ -111,7 +107,6 @@ defmodule GroupherServerWeb.Schema.CMS.Types do
     general_article_fields()
     comments_fields()
 
-    field(:length, :integer)
     field(:link_addr, :string)
 
     timestamp_fields(:article)
@@ -123,7 +118,6 @@ defmodule GroupherServerWeb.Schema.CMS.Types do
     general_article_fields()
     comments_fields()
 
-    field(:length, :integer)
     field(:link_addr, :string)
 
     timestamp_fields(:article)

lib/groupher_server_web/schema/cms/mutations/blog.ex

@@ -11,7 +11,6 @@ defmodule GroupherServerWeb.Schema.CMS.Mutations.Blog do
       arg(:title, non_null(:string))
       arg(:body, non_null(:string))
       arg(:digest, non_null(:string))
-      arg(:length, :integer)
       arg(:community_id, non_null(:id))
       arg(:link_addr, :string)
       arg(:thread, :thread, default_value: :blog)
@@ -29,7 +28,6 @@ defmodule GroupherServerWeb.Schema.CMS.Mutations.Blog do
       arg(:title, :string)
       arg(:body, :string)
       arg(:digest, :string)
-      arg(:length, :integer)
       arg(:link_addr, :string)
 
       arg(:article_tags, list_of(:id))

lib/groupher_server_web/schema/cms/mutations/job.ex

@@ -34,7 +34,6 @@ defmodule GroupherServerWeb.Schema.CMS.Mutations.Job do
       arg(:title, :string)
       arg(:body, :string)
       arg(:digest, :string)
-      arg(:length, :integer)
       arg(:copy_right, :string)
       arg(:desc, :string)
       arg(:link_addr, :string)

test/groupher_server/cms/articles/drink_test.exs

@@ -169,7 +169,6 @@ defmodule GroupherServer.Test.Articles.Drink do
       assert article_doc.body == drink_doc.body
     end
 
-    @tag :wip
     test "delete drink should also delete related document", ~m(user community drink_attrs)a do
       {:ok, drink} = CMS.create_article(community, :drink, drink_attrs, user)
       {:ok, _article_doc} = ORM.find_by(ArticleDocument, %{article_id: drink.id, thread: "DRINK"})

test/groupher_server/cms/articles/guide_test.exs

@@ -169,7 +169,6 @@ defmodule GroupherServer.Test.Articles.Guide do
       assert article_doc.body == guide_doc.body
     end
 
-    @tag :wip
     test "delete guide should also delete related document", ~m(user community guide_attrs)a do
       {:ok, guide} = CMS.create_article(community, :guide, guide_attrs, user)
       {:ok, _article_doc} = ORM.find_by(ArticleDocument, %{article_id: guide.id, thread: "GUIDE"})

test/groupher_server/cms/articles/meetup_test.exs

@@ -171,7 +171,6 @@ defmodule GroupherServer.Test.Articles.Meetup do
       assert article_doc.body == meetup_doc.body
     end
 
-    @tag :wip
     test "delete meetup should also delete related document", ~m(user community meetup_attrs)a do
       {:ok, meetup} = CMS.create_article(community, :meetup, meetup_attrs, user)
 

test/groupher_server/cms/articles/radar_test.exs

@@ -169,7 +169,6 @@ defmodule GroupherServer.Test.Articles.Radar do
       assert article_doc.body == radar_doc.body
     end
 
-    @tag :wip
     test "delete radar should also delete related document", ~m(user community radar_attrs)a do
       {:ok, radar} = CMS.create_article(community, :radar, radar_attrs, user)
       {:ok, _article_doc} = ORM.find_by(ArticleDocument, %{article_id: radar.id, thread: "RADAR"})

test/groupher_server/cms/articles/works_test.exs

@@ -169,7 +169,6 @@ defmodule GroupherServer.Test.Articles.Works do
       assert article_doc.body == works_doc.body
     end
 
-    @tag :wip
     test "delete works should also delete related document", ~m(user community works_attrs)a do
       {:ok, works} = CMS.create_article(community, :works, works_attrs, user)
       {:ok, _article_doc} = ORM.find_by(ArticleDocument, %{article_id: works.id, thread: "WORKS"})

test/groupher_server_web/mutation/cms/articles/job_test.exs

@@ -87,6 +87,7 @@ defmodule GroupherServer.Test.Mutation.Articles.Job do
       assert exist_in?(%{id: article_tag.id}, job.article_tags)
     end
 
+    @tag :wip
     test "create job should excape xss attracts" do
       {:ok, user} = db_insert(:user)
       user_conn = simu_conn(:user, user)

test/groupher_server_web/mutation/cms/articles/meetup_test.exs

@@ -85,7 +85,6 @@ defmodule GroupherServer.Test.Mutation.Articles.Meetup do
       assert exist_in?(%{id: article_tag.id}, meetup.article_tags)
     end
 
-    @tag :wip
     test "create meetup should excape xss attracts" do
       {:ok, user} = db_insert(:user)
       user_conn = simu_conn(:user, user)