refactor(cite-task): fix citing self edge-case

Author: mydearxym

lib/groupher_server/cms/delegates/cite_tasks.ex

@@ -76,8 +76,7 @@ defmodule GroupherServer.CMS.Delegate.CiteTasks do
     end
   end
 
-  # defp batch_done
-
+  # batch insert CitedContent record and update citing count
   defp update_cited_info(cited_contents) do
     # see: https://github.com/elixir-ecto/ecto/issues/1932#issuecomment-314083252
     clean_cited_contents =
@@ -86,10 +85,9 @@ defmodule GroupherServer.CMS.Delegate.CiteTasks do
       |> Enum.map(&Map.delete(&1, :cited_content))
       |> Enum.map(&Map.delete(&1, :citing_time))
 
-    with true <- {0, nil} !== Repo.insert_all(CitedContent, clean_cited_contents) do
-      update_citing_count(cited_contents)
-    else
-      _ -> {:error, "insert cited content error"}
+    case {0, nil} !== Repo.insert_all(CitedContent, clean_cited_contents) do
+      true -> update_citing_count(cited_contents)
+      false -> {:error, "insert cited content error"}
     end
   end
 
@@ -166,31 +164,31 @@ defmodule GroupherServer.CMS.Delegate.CiteTasks do
     do_parse_cited_info(content, block_id, links)
   end
 
-  defp do_parse_cited_info(%Comment{} = comment, block_id, links) do
-    # IO.inspect(links, label: "links -> ")
-
-    Enum.reduce(links, [], fn link, acc ->
-      case parse_cited(link) do
-        {:ok, cited} -> List.insert_at(acc, 0, shape_cited(comment, cited, block_id))
-        _ -> acc
-      end
-    end)
-    |> Enum.uniq()
-  end
-
   # links Floki parsed fmt
+  # content means both article and comment
   # e.g:
   # [{"a", [{"href", "https://coderplanets.com/post/195675"}], []},]
-  defp do_parse_cited_info(article, block_id, links) do
+  defp do_parse_cited_info(content, block_id, links) do
     Enum.reduce(links, [], fn link, acc ->
-      case parse_cited(link) do
-        {:ok, cited} -> List.insert_at(acc, 0, shape_cited(article, cited, block_id))
+      case parse_valid_cited(content.id, link) do
+        {:ok, cited} -> List.insert_at(acc, 0, shape_cited(content, cited, block_id))
         _ -> acc
       end
     end)
     |> Enum.uniq()
   end
 
+  # parse cited with check if citing link is point to itself
+  defp parse_valid_cited(content_id, link) do
+    with {:ok, cited} <- parse_cited(link),
+         %{content: content} <- cited do
+      case content.id !== content_id do
+        true -> {:ok, cited}
+        false -> {:error, "citing itself"}
+      end
+    end
+  end
+
   # cite article in comment
   # 在评论中引用文章
   defp shape_cited(%Comment{} = comment, %{type: :article, content: cited}, block_id) do

test/groupher_server/cms/cite_contents/cite_blog_test.exs

@@ -73,6 +73,24 @@ defmodule GroupherServer.Test.CMS.CiteContent.Blog do
       assert blog.meta.citing_count == 0
     end
 
+    @tag :wip
+    test "cited comment itself should not work", ~m(user blog)a do
+      {:ok, cited_comment} = CMS.create_comment(:blog, blog.id, mock_rich_text("hello"), user)
+
+      {:ok, comment} =
+        CMS.update_comment(
+          cited_comment,
+          mock_comment(
+            ~s(the <a href=#{@site_host}/blog/#{blog.id}?comment_id=#{cited_comment.id} />)
+          )
+        )
+
+      CiteTasks.handle(comment)
+
+      {:ok, cited_comment} = ORM.find(Comment, cited_comment.id)
+      assert cited_comment.meta.citing_count == 0
+    end
+
     @tag :wip
     test "can cite blog's comment in blog", ~m(community user blog blog2 blog_attrs)a do
       {:ok, comment} = CMS.create_comment(:blog, blog.id, mock_rich_text("hello"), user)

test/groupher_server/cms/cite_contents/cite_job_test.exs

@@ -73,6 +73,24 @@ defmodule GroupherServer.Test.CMS.CiteContent.Job do
       assert job.meta.citing_count == 0
     end
 
+    @tag :wip
+    test "cited comment itself should not work", ~m(user job)a do
+      {:ok, cited_comment} = CMS.create_comment(:job, job.id, mock_rich_text("hello"), user)
+
+      {:ok, comment} =
+        CMS.update_comment(
+          cited_comment,
+          mock_comment(
+            ~s(the <a href=#{@site_host}/job/#{job.id}?comment_id=#{cited_comment.id} />)
+          )
+        )
+
+      CiteTasks.handle(comment)
+
+      {:ok, cited_comment} = ORM.find(Comment, cited_comment.id)
+      assert cited_comment.meta.citing_count == 0
+    end
+
     @tag :wip
     test "can cite job's comment in job", ~m(community user job job2 job_attrs)a do
       {:ok, comment} = CMS.create_comment(:job, job.id, mock_rich_text("hello"), user)

test/groupher_server/cms/cite_contents/cite_post_test.exs

@@ -62,6 +62,7 @@ defmodule GroupherServer.Test.CMS.CiteContent.Post do
       assert post5.meta.citing_count == 1
     end
 
+    @tag :wip
     test "cited post itself should not work", ~m(user community post_attrs)a do
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
 
@@ -74,6 +75,24 @@ defmodule GroupherServer.Test.CMS.CiteContent.Post do
       assert post.meta.citing_count == 0
     end
 
+    @tag :wip
+    test "cited comment itself should not work", ~m(user post)a do
+      {:ok, cited_comment} = CMS.create_comment(:post, post.id, mock_rich_text("hello"), user)
+
+      {:ok, comment} =
+        CMS.update_comment(
+          cited_comment,
+          mock_comment(
+            ~s(the <a href=#{@site_host}/post/#{post.id}?comment_id=#{cited_comment.id} />)
+          )
+        )
+
+      CiteTasks.handle(comment)
+
+      {:ok, cited_comment} = ORM.find(Comment, cited_comment.id)
+      assert cited_comment.meta.citing_count == 0
+    end
+
     @tag :wip
     test "can cite post's comment in post", ~m(community user post post2 post_attrs)a do
       {:ok, comment} = CMS.create_comment(:post, post.id, mock_rich_text("hello"), user)