refactor(renaming): error: error -> error: reason

Author: mydearxym

lib/groupher_server/accounts/delegates/fans.ex

@@ -40,8 +40,8 @@ defmodule GroupherServer.Accounts.Delegate.Fans do
       false ->
         {:error, [message: "can't follow yourself", code: ecode(:self_conflict)]}
 
-      {:error, error} ->
-        {:error, [message: error, code: ecode(:not_exsit)]}
+      {:error, reason} ->
+        {:error, [message: reason, code: ecode(:not_exsit)]}
     end
   end
 
@@ -89,8 +89,8 @@ defmodule GroupherServer.Accounts.Delegate.Fans do
       false ->
         {:error, [message: "can't undo follow yourself", code: ecode(:self_conflict)]}
 
-      {:error, error} ->
-        {:error, [message: error, code: ecode(:not_exsit)]}
+      {:error, reason} ->
+        {:error, [message: reason, code: ecode(:not_exsit)]}
     end
   end
 

lib/groupher_server/accounts/delegates/favorite_category.ex

@@ -149,7 +149,7 @@ defmodule GroupherServer.Accounts.Delegate.FavoriteCategory do
           {:error, _} ->
             case CMS.reaction(thread, :favorite, content_id, user) do
               {:ok, _} -> find_content_favorite(thread, content_id, user.id)
-              {:error, error} -> {:error, error}
+              {:error, reason} -> {:error, reason}
             end
         end
       end)
@@ -160,7 +160,7 @@ defmodule GroupherServer.Accounts.Delegate.FavoriteCategory do
           |> ORM.update(%{total_count: max(old_category.total_count - 1, 0)})
         else
           true -> {:ok, ""}
-          error -> {:error, error}
+          reason -> {:error, reason}
         end
       end)
       |> Multi.run(:update_content_category_id, fn _, %{favorite_content: content_favorite} ->

lib/groupher_server/cms/delegates/community_curd.ex

@@ -174,8 +174,8 @@ defmodule GroupherServer.CMS.Delegate.CommunityCURD do
       {:ok, ret} ->
         {:ok, ret}
 
-      {:error, error} ->
-        {:error, error}
+      {:error, reason} ->
+        {:error, reason}
     end
   end
 

lib/helper/utils.ex

@@ -35,7 +35,7 @@ defmodule Helper.Utils do
   def done(_, :boolean), do: {:ok, true}
   def done(nil, err_msg), do: {:error, err_msg}
   def done({:ok, _}, with: result), do: {:ok, result}
-  def done({:error, error}, with: _result), do: {:error, error}
+  def done({:error, reason}, with: _result), do: {:error, reason}
 
   def done({:ok, %{id: id}}, :status), do: {:ok, %{done: true, id: id}}
   def done({:error, _}, :status), do: {:ok, %{done: false}}
@@ -48,8 +48,6 @@ defmodule Helper.Utils do
   # for delete_all, update_all
   # see: https://groups.google.com/forum/#!topic/elixir-ecto/1g5Pp6ceqFE
   def done({n, nil}) when is_integer(n), do: {:ok, %{done: true}}
-
-  # def done({:error, error}), do: {:error, error}
   def done(result), do: {:ok, result}
 
   def done_and_cache(result, scope, expire: expire_time) do

test/groupher_server/accounts/favorite_category_test.exs

@@ -28,9 +28,9 @@ defmodule GroupherServer.Test.Accounts.FavoriteCategory do
 
     test "user create dup favorite category fails", ~m(user)a do
       {:ok, _category} = Accounts.create_favorite_category(user, %{title: "test category"})
-      {:error, error} = Accounts.create_favorite_category(user, %{title: "test category"})
+      {:error, reason} = Accounts.create_favorite_category(user, %{title: "test category"})
 
-      assert error |> Keyword.get(:code) == ecode(:already_exsit)
+      assert reason |> Keyword.get(:code) == ecode(:already_exsit)
     end
 
     test "user can get public categories list", ~m(user)a do
@@ -120,8 +120,8 @@ defmodule GroupherServer.Test.Accounts.FavoriteCategory do
       {:ok, category} = Accounts.create_favorite_category(user, %{title: test_category})
       {:ok, _} = Accounts.set_favorites(user, :post, post.id, category.id)
 
-      {:error, error} = Accounts.set_favorites(user, :post, post.id, category.id)
-      assert error |> Keyword.get(:code) == ecode(:already_did)
+      {:error, reason} = Accounts.set_favorites(user, :post, post.id, category.id)
+      assert reason |> Keyword.get(:code) == ecode(:already_did)
     end
 
     test "user can unset category to a favorited post", ~m(user post)a do

test/groupher_server/billing/billing_test.exs

@@ -36,8 +36,8 @@ defmodule GroupherServer.Test.Billing do
 
     test "create bill record with previous record unhandled fails", ~m(user valid_attrs)a do
       {:ok, _record} = Billing.create_record(user, valid_attrs)
-      {:error, error} = Billing.create_record(user, valid_attrs)
-      assert error |> Keyword.get(:code) == ecode(:exsit_pending_bill)
+      {:error, reason} = Billing.create_record(user, valid_attrs)
+      assert reason |> Keyword.get(:code) == ecode(:exsit_pending_bill)
     end
 
     test "record state can be update", ~m(user valid_attrs)a do

test/groupher_server/cms/cheatsheet_test.exs

@@ -58,8 +58,8 @@ defmodule GroupherServer.Test.CMS.Cheatsheet do
       assert length(update_contributors) == 1 + length(cur_contributors)
 
       # add some again
-      {:error, error} = CMS.add_contributor(cheatsheet, contributor_attrs)
-      assert error |> Keyword.get(:code) == ecode(:already_exsit)
+      {:error, reason} = CMS.add_contributor(cheatsheet, contributor_attrs)
+      assert reason |> Keyword.get(:code) == ecode(:already_exsit)
     end
   end
 end

test/groupher_server/cms/wiki_test.exs

@@ -56,8 +56,8 @@ defmodule GroupherServer.Test.Wiki do
       assert length(update_contributors) == 1 + length(cur_contributors)
 
       # add some again
-      {:error, error} = CMS.add_contributor(wiki, contributor_attrs)
-      assert error |> Keyword.get(:code) == ecode(:already_exsit)
+      {:error, reason} = CMS.add_contributor(wiki, contributor_attrs)
+      assert reason |> Keyword.get(:code) == ecode(:already_exsit)
     end
   end
 end