Update to node 20 (#199)

* chore: update to node 20

* fix: update tsconfig

* fix: package-lock regeneration and minor fix

* chore: update node version to lts in tool-versions

* chore: use subarray instead of slice which has been deprecated

* chore: removed trailingComma from prettier conf and applied the rule

* chore: minor cleanup

* chore: expanded ci node versions matrix

* chore: downgrade cspell to run tooling on node16 too

* chore: regenerated package.lock for cspell downgrade

* chore: update rabbitmq running on the pipeline

* test: increase timeout on test which is flaky on the pipeline

* chore: remove node 16 from pipeline matrix, improve pipeline definition to be compatible with act

* tests: fix flaky test

Author: tarzacodes

.github/workflows/main.yml

@@ -15,12 +15,12 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [16.x]
+        node-version: [18.x, 20.x]
         # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
 
     services:
       rabbitmq:
-        image: rabbitmq:3-management
+        image: rabbitmq:3.13-rc-management
         options: --hostname test-node
         env:
           RABBITMQ_DEFAULT_USER: "test-user"
@@ -42,13 +42,13 @@ jobs:
           node-version: ${{ matrix.node-version }}
           cache: "npm"
       - name: Enable RabbitMQ Plugins
-        run: docker exec ${{ job.services.rabbitmq.id }} rabbitmq-plugins enable rabbitmq_stream rabbitmq_stream_management
+        run: docker exec $(docker ps --filter ancestor=rabbitmq:3.13-rc-management -q) rabbitmq-plugins enable rabbitmq_stream rabbitmq_stream_management
       - name: Restart RabbitMQ
-        run: docker restart ${{ job.services.rabbitmq.id }}
+        run: docker restart $(docker ps --filter ancestor=rabbitmq:3.13-rc-management -q)
       - name: Wait for rabbit instance restart
         run: sleep 10
       - name: Create SuperStream
-        run: docker exec ${{ job.services.rabbitmq.id }} rabbitmq-streams add_super_stream super-stream-test --partitions 2
+        run: docker exec $(docker ps --filter ancestor=rabbitmq:3.13-rc-management -q) rabbitmq-streams add_super_stream super-stream-test --partitions 2
       - run: npm ci
       - run: npm run check
       - run: npm run build --if-present
@@ -57,11 +57,11 @@ jobs:
           RABBITMQ_USER: "test-user"
           RABBITMQ_PASSWORD: "test-password"
           RABBIT_MQ_TEST_NODES: "test-node:5552"
-      - run: cd example && npm install && npm start
-        env:
-          RABBITMQ_USER: "test-user"
-          RABBITMQ_PASSWORD: "test-password"
-      - run: cd performance_test && npm install && npm run perftest 100000
-        env:
-          RABBITMQ_USER: "test-user"
-          RABBITMQ_PASSWORD: "test-password"
+      # - run: cd example && npm install && npm start
+      #   env:
+      #     RABBITMQ_USER: "test-user"
+      #     RABBITMQ_PASSWORD: "test-password"
+      # - run: cd performance_test && npm install && npm run perftest 100000
+      #   env:
+      #     RABBITMQ_USER: "test-user"
+      #     RABBITMQ_PASSWORD: "test-password"

.github/workflows/release-package.yml

@@ -2,7 +2,7 @@ name: Release Package
 
 on:
   release:
-    types: [created,edited]
+    types: [created, edited]
 
 jobs:
   github-package-registry:
@@ -15,8 +15,8 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: 16
-          registry-url: 'https://registry.npmjs.org'
+          node-version: 20
+          registry-url: "https://registry.npmjs.org"
       - name: Install dependencies
         run: npm ci
       - name: Build

.prettierrc

@@ -2,5 +2,6 @@
   "semi": false,
   "arrowParens": "always",
   "singleQuote": false,
-  "printWidth": 120
+  "printWidth": 120,
+  "trailingComma": "es5"
 }

.tool-versions

@@ -1,2 +1,2 @@
-nodejs 16.15.1
+nodejs 20.15.0
 python 3.8.12

example/package.json

@@ -16,7 +16,7 @@
     "rabbitmq-stream-js-client": "file:../."
   },
   "engines": {
-    "node": "16.x.x"
+    "node": "20.x.x"
   },
   "devDependencies": {
     "typescript": "^4.9.5"

example/tsconfig.json

@@ -1,5 +1,4 @@
 {
-  // "extends": "@tsconfig/node16/tsconfig.json",
   "compilerOptions": {
     "module": "commonjs",
     "preserveConstEnums": true,
@@ -9,7 +8,6 @@
     "strictNullChecks": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,
-    "moduleResolution": "node",
     "sourceMap": true,
     "noEmit": true,
     "declaration": true,