Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore Page: Switching between sandboxes doesn't update the code #1439

Closed
CompuIves opened this issue Jan 8, 2019 · 7 comments
Closed

Explore Page: Switching between sandboxes doesn't update the code #1439

CompuIves opened this issue Jan 8, 2019 · 7 comments

Comments

@CompuIves
Copy link
Member

When having a sandbox open on the explore page and switching between sandboxes the code of the embed doesn't change.

This is probably a componentDidUpdate that we need to change in the embed.

@lbogdan
Copy link
Contributor

lbogdan commented Mar 26, 2019

What do you mean by "the code of the embed"? The URL that's copied to the clipboard when you click "Copy Link"? If so, it's changing for me, so maybe you fixed it in the meanwhile?

Buuut, while clicking around in the explore page, I just noticed another weird behavior - for me, the preview never changes. 😞

@samrith-s
Copy link
Contributor

Any way I can run the Explore page? I just get this some errors in the console.

image

@CompuIves
Copy link
Member Author

Hey! You can start it by going to packages/homepage and running yarn start:dev. I think the origin of this issue is in the preview component (packages/common/components/Preview), so if you work on that component you also need to run yarn start in packages/common.

@samrith-s
Copy link
Contributor

Hey, got it. I’ll do that and check out this issue. Faced the same thing yesterday. Thanks!

@CompuIves
Copy link
Member Author

Hey @samrith-s, did you find anything here? I'm thinking on taking a stab today.

@samrith-s
Copy link
Contributor

Hey @CompuIves, I’m gonna have a stab at it later tonight! You can try as well, would love to know how you approach it!

@CompuIves
Copy link
Member Author

This (#1715) fixed this as well, so we can close this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants