Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console.log() in manager.js #164

Closed
lbogdan opened this issue Sep 2, 2017 · 4 comments
Closed

console.log() in manager.js #164

lbogdan opened this issue Sep 2, 2017 · 4 comments

Comments

@lbogdan
Copy link
Contributor

lbogdan commented Sep 2, 2017

There's a console.log() in https://github.com/CompuIves/codesandbox-client/blob/master/src/sandbox/eval/manager.js#L45 , which also shows in production. Is this needed?

@CompuIves
Copy link
Member

Yep, this is on purpose for easier debugging. I'm planning to keep it until next week.

@lbogdan
Copy link
Contributor Author

lbogdan commented Sep 2, 2017

Roger that. 😄

@lbogdan lbogdan closed this as completed Sep 2, 2017
@lbogdan
Copy link
Contributor Author

lbogdan commented Sep 2, 2017

Actually, I'll just leave this open as a reminder. 😄

@lbogdan lbogdan reopened this Sep 2, 2017
@CompuIves
Copy link
Member

Put this behind an environment flag 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants