Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative images not showing up with Parcel #687

Closed
francoischalifour opened this issue Apr 2, 2018 · 3 comments · May be fixed by adamlaska/codesandbox-client#160
Closed

Relative images not showing up with Parcel #687

francoischalifour opened this issue Apr 2, 2018 · 3 comments · May be fixed by adamlaska/codesandbox-client#160

Comments

@francoischalifour
Copy link
Contributor

Hey there!

It seems like imgs with relative paths are not working with the Parcel template (they're not displayed).

A few things I noticed:

  • An image with an absolute source (from an external website) displays correctly
  • imgs are not present in the DOM (they seem to be skipped during the build process)
  • No errors are thrown (while an error is thrown when the image path is wrong)

This example is working fine locally on my machine and on Zeit. That's why I think it's an issue on CodeSandbox's side.

I'm not sure if this issue is related to #100.

@CompuIves
Copy link
Member

This is a perfect reproduction and super clear issue. I'll fix this now!

@CompuIves
Copy link
Member

It's live, you may need to do a hard reload to see the changes!

@francoischalifour
Copy link
Contributor Author

You're awesome! Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants