Skip to content
This repository has been archived by the owner on Feb 4, 2022. It is now read-only.

feat: add event emitting for intermediary state changes [CSB-882] #2

Merged
merged 4 commits into from
Aug 11, 2021

Conversation

matchai
Copy link
Contributor

@matchai matchai commented Aug 10, 2021

In order to be able to reflect MemoryFS changes in the filesystem, we'll need to replicate the intermediary stages of MemoryFS operations when it is conflict resolving. Neglecting to do so will cause filesystem errors due to impossible filesystem states.

Changes

  • Add an event emitter to crdt-tree emitting intermediary operations between "true" logged operations

@matchai matchai requested a review from DeMoorJasper August 10, 2021 18:33
@matchai matchai changed the title feat: add intermediary event emitting feat: add event emitting for intermediary state changes Aug 10, 2021
@github-actions
Copy link

github-actions bot commented Aug 10, 2021

size-limit report 📦

Path Size
dist/crdt-tree.cjs.production.min.js 1.88 KB (+16.45% 🔺)
dist/crdt-tree.esm.js 1.85 KB (+13.12% 🔺)

@matchai matchai marked this pull request as draft August 11, 2021 12:49
@matchai matchai changed the title feat: add event emitting for intermediary state changes feat: add event emitting for intermediary state changes [CSB-882] Aug 11, 2021
@linear
Copy link

linear bot commented Aug 11, 2021

CSB-882 Allow users to create new directories via the UI

CleanShot 2021-08-07 at 10.01.52@2x.png

  • Creating directories works in the UI. These are persisted, but I'm not sure where?
  • Those directories, and any nested files are not tracked in git or persisted to the file system of the container 🤔

@matchai matchai changed the base branch from main to beta August 11, 2021 15:02
@matchai matchai marked this pull request as ready for review August 11, 2021 16:18
@matchai matchai merged commit cb752d4 into beta Aug 11, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.3.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matchai added a commit that referenced this pull request Aug 23, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* feat: add intermediary event emitting

* Clarify test steps

* Flatten the parent's tree when emitting intermediary ops

* Set up husky & lint
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants