Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command make install does not work On MacOS #1

Open
sinistersnare opened this issue Jan 23, 2019 · 5 comments
Open

Command make install does not work On MacOS #1

sinistersnare opened this issue Jan 23, 2019 · 5 comments
Assignees
Labels
bug Something isn't working cross-platform

Comments

@sinistersnare
Copy link

sinistersnare commented Jan 23, 2019

Running

$ git clone $MNEMONIC
$ cd mnemonic
$ sudo make install
find: illegal option -- t
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]
install -m 0755 -v ./target/release/mn /usr/local/bin/mn
install: ./target/release/mn -> /usr/local/bin/mn
cp /mn.1 /usr/local/share/man/man1/mn.1
cp: /mn.1: No such file or directory
make: *** [install] Error 1

I thought this had to do with the Cargo build, but it seems to be about install the manpages.

Anyways, I think I will use this to replace my usage of MacOS Notes.App, thanks for making it!

@sinistersnare sinistersnare changed the title Command make install does not work without having built the library already. Command make install does not work On MacOS Jan 23, 2019
@codesections
Copy link
Owner

Very interesting! It turns out that MacOS uses the BSD implementation of the find command, so my use of the --type flag wasn't valid. I've updated the makefile to use only the -path flag, which should be supported by both programs. Can you let me know if this solves the issue and correctly installs the man page?

And yes, the makefile currently does not build the binary, just installs it to the users path. Would it be better to add building the binary as part of the makefile? I wasn't sure of best practice there.

In any event, thanks for the feedback and glad you like it.

@codesections codesections added bug Something isn't working cross-platform labels Jan 23, 2019
@codesections codesections self-assigned this Jan 23, 2019
@codesections
Copy link
Owner

Closing this as resolved. Let me know if it isn't and I'll reopen.

@sinistersnare
Copy link
Author

▶ find -path "./target/release/build/mn-*/out"
find: illegal option -- p

Looks like not even -path is working.

@codesections codesections reopened this Jan 24, 2019
@codesections
Copy link
Owner

Hmm, I'll have to take another look at this. Thanks for the testing.

@codesections
Copy link
Owner

I have updated the makefile to not use find at all. Does the current version work on a mac?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cross-platform
Projects
None yet
Development

No branches or pull requests

2 participants