Allow to pass option to avoid comments and emptyLines in sample env #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codeshifu This is super useful for a lot of users; would you mind reviewing this PR please? |
|
@paambaati thanks for bringing my attention to this! I really am not sure how I missed it 🤦🏽♂️ @danieldspx I apologize for taking so long to attend to this. |
|
LGTM 🚀 Released v2.7.0. Thanks again @danieldspx @paambaati |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have a pre-commit hook set-up and for some reason we comment a secret, this might end up commited. To avoid this, we can give the option to avoid comments or even empty lines.
Given the problem, this PR gives the lib the ability to accept those options and avoid any further problem with secrets commit on sample envs.
NOTE: This problem happened to me and to my colleagues so I think it is reasonable to have this feature.