Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributor page using github api #5

Closed
akshitdesai opened this issue Dec 3, 2020 · 9 comments · Fixed by #10
Closed

Add contributor page using github api #5

akshitdesai opened this issue Dec 3, 2020 · 9 comments · Fixed by #10
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@akshitdesai
Copy link
Owner

In about page list contributors of this repository using GitHub API. Try to initiate the work. Improvements can be done later.

@akshitdesai akshitdesai added good first issue Good for newcomers enhancement New feature or request labels Dec 3, 2020
@akshitdesai
Copy link
Owner Author

@matt-ross16
Copy link
Contributor

I'd like to try to get this running for you

@akshitdesai
Copy link
Owner Author

Ok, Sure!! Go for it.

@matt-ross16
Copy link
Contributor

For the about page, where are you hoping to have this featured? Prior to logging in, or only after authentication?

I considered placing it as a template, but wanted to see what you preferred

@akshitdesai
Copy link
Owner Author

Ya, place it as a template.

@matt-ross16
Copy link
Contributor

Ok, this is what I have so far:

image

The profile pictures are clickable and open a new tab for the user's profile page, and then I have the username and the number of contributions they've made listed.

Formatting could be improved, but thought I'd take suggestions on that!

@matt-ross16
Copy link
Contributor

matt-ross16 commented Dec 7, 2020

Here's the commit so far:
matt-ross16@5b8919d

@matt-ross16
Copy link
Contributor

New look!

image

Hovering over the profile images will provide the username and the number of contributions rather than clogging up the screen with the info

@akshitdesai
Copy link
Owner Author

Thank you!! @matt-ross16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants