-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fargate support #23
base: master
Are you sure you want to change the base?
Fargate support #23
Conversation
…ainer instance ARNs (fargate)
Can this be merged anytime soon? Really want to try quick. |
I am on holiday right now, but I'll try to have a look. Thanks for the PR! Much appreciated. |
I finally had a look at the code. |
I found the answer. So could you rewrite the code a little. If the networking is bridge then do the same as current If you feel super motivated you could also add support for host networking by just using the instance IP + container port. (A mix of the other two) |
Is this PR still alive? :) |
Sorry, I've been busy. Will try to look at the suggestions this weekend. |
We quickly declared |
@anbotero Hi there. Recently I am exclusively using Google Cloud so I have no chance to test things on AWS. |
Fixes fargate support from the
ecs-nginx-proxy
project.New to: go, amazon ecs, and fargate so this is definitely a hack, but it works for me! Feedback would be appreciated.