-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate - String repeat #109
Comments
My opinion:
I did not check edge cases in any of the kata, but following tests could be interesting:
I don't know if any of the listed kata contains such tests. |
Keep 1 and 6. Retire 2, 3 (it is just a combination of two existing 8 kyu tasks), 4, 5. I vote to keep 6 because it is a slight variation of 1 (which is fine for an 8 kyu kata) and I like its Haskell solution. |
Regarding 4, tests cannot be bypassed easily since Retire
I have no strong opinion in retiring or keeping 4. since some solutions in Since 6 involves handling different data types (strings & characters) in typed languages, I think it can be kept. EDIT: Woops missed that one, sry 😅 Yeah, retired 7. too due to useless input validation |
Keep 1 and 6, retire the others. |
I agree with keeping 6, but I don't actually see any difference between any of the 1 - 5 katas. Keeping also 1, if everyone agrees with it, seems fair. |
Keep 1 only. But I'm not against keeping 6 if the opinion is general |
I think this kata should be added to the list: https://www.codewars.com/kata/557af9418895e44de7000053 I didn't examine it, seems a mere duplicate of 1, with extra input validation. |
Oh ejini how could you :D |
Keep 1 and 6. monadius is right, 6 deserves to be kept if only for the haskell translation. |
keeping 1 and 6 sounds fine to me |
If not stated otherwise, all kata take a string and a count as arguments and expect a return value of the string repeated requested amount of times.
repeat
forbidden but ejini reports it can be bypass easilyADDED:
Conclusion
Since kata 1. covers all languages available in other kata, there's no need to move any translations.
The text was updated successfully, but these errors were encountered: