Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate - sum of intervals #117

Closed
hobovsky opened this issue Aug 12, 2022 · 7 comments
Closed

Deduplicate - sum of intervals #117

hobovsky opened this issue Aug 12, 2022 · 7 comments
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata

Comments

@hobovsky
Copy link
Contributor

hobovsky commented Aug 12, 2022

  1. Sum of Intervals
  • 4 kyu
  • 92% of 25k solutions
  • 3 pending issues, one about inconsistent difficulty between languages
  • 20 approved languages + 4 pending translations
  • Published Dec 2013, author inactive
  1. How many days are we represented in a foreign country?
  • 7 kyu
  • 88% with 1.8k completions
  • No pending issues
  • 7 languages, no pending translations. Nim not present in 1.
  • Published Apr 2017, author active

Conclusion

@hobovsky
Copy link
Contributor Author

hobovsky commented Aug 12, 2022

The problem here is that 1. is meant to be difficult, but some languages (reportedly including Python) can be passed with a solution which passes also the 7 kyu version.

I think I'd still say the kata are not duplicates: kata 2. does not really spoil solutions for 1., and 1. should be just fixed to accept solutions of appropriate complexity.

@Blind4Basics
Copy link

Blind4Basics commented Aug 12, 2022

iirc, there are some other kata in yellow level reuqiring the same kind of stuff (& enforcing performances) so.... retire 1?

Suggesting this, because I doubt fixing 20 languages will ever actually happen.

@monadius
Copy link

@Blind4Basics do you have links to other similar kata with performance requirements? I already fixed several languages in 1. There is an easy fix: It is enough to increase bounds of intervals. This fix does not eliminate all O(n^2) solutions but remaining solutions are more complex than the intended solution. I am going to fix all languages soon. So I vote to keep both 1 and 2.

@Blind4Basics
Copy link

you know how it is about finding something in the DB... (those kata obviously don't have sum of intervals in their name). Ok, if you can fix the languages, 👍

@hobovsky hobovsky moved this to Filling gaps in Deduplication process Aug 14, 2022
@hobovsky hobovsky moved this from Filling gaps to Discussing in Deduplication process Aug 14, 2022
@hobovsky
Copy link
Contributor Author

I think we can safely conclude this set as not duplicates. We need to identify nonconformant languages in 1. and fix it.

@hobovsky hobovsky moved this from Discussing to Done in Deduplication process Aug 19, 2022
@monadius
Copy link

I will try to fix all languages in 1 some time next week.

@monadius
Copy link

monadius commented Aug 23, 2022

Tasks:

  • Make sure that large interval tests are present.
  • Large interval tests should not be passed with max - min solutions and with set-based solutions.
  • Endpoints of large intervals should be in the range [-1e9, 1e9].

Languages with large interval tests:

  • C
  • Clojure
  • COBOL
  • CoffeeScript
  • C++
  • Crystal
  • C#
  • Dart
  • Elixir
  • Go
  • Haskell
  • Java
  • JavaScript
  • Julia
  • NASM
  • PHP
  • Python
  • Racket
  • Ruby
  • Rust
  • TypeScript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata
Projects
Development

No branches or pull requests

3 participants