-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate - Vector class #121
Comments
I think this kata is nice to exercise objects and classes in various languages, so it's good to have it, and it's good to have some variety it brings. But still, three kata might be too many. Between 1. and 2. I think I like 2. more due to its larger scope, but it could use some technical improvements. It suffers from FP precision issues, and sometimes assertion messages are not very clear. I would vote to retire 1. and keep 2. as more interesting, potentially reporting/fixing its issues. Between 3. and the others, I am not really sure but I think I'd vote to keep 3. It is very similar to 1. w.r.t. the set of required operations, but the arbitrary size of the vectors requires different approach. Additionally, I think this kind of tasks is a place where some repetition is good to have for learning purposes. I will not object too much though if community would decide to retire it as a duplicate of 1. or 2. |
Agree with retiring 1 and conserving 2 and 3. |
I agree with retiring 1 and keeping the others. |
Retire 1. |
don't have a strong opinion, but retiring 1 sounds fine |
I think that conclusion is quite clear to retire 1. and keep 2., but this means that three translation have to be moved, and the kata has quite a large scope, so any help is welcome! |
Just an updated: I've published a Python translations for 2. |
Vector class
Conclusion
Filling gaps
The text was updated successfully, but these errors were encountered: