Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate - Vector class #121

Open
4 tasks
hobovsky opened this issue Aug 16, 2022 · 7 comments
Open
4 tasks

Deduplicate - Vector class #121

hobovsky opened this issue Aug 16, 2022 · 7 comments
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata language/java language/python language/ruby

Comments

@hobovsky
Copy link
Contributor

hobovsky commented Aug 16, 2022

Vector class

  1. Vector Class
  • 5 kyu
  • Vectors in 3D
  • 93% with 700+ completions
  • 1 pending issue
  • 2 languages (Python, Ruby) + 1 pending translation (Java)
  • Published Mar 2014, author inactive
  1. Program a Calculator #2 - 3D Vectors
  • 5 kyu
  • Vectors in 3D
  • Much more detailed than 1., asks for more operations.
  • 89% with 188 completions
  • 2 pending issues
  • 4 languages (C#, JavaScript, Python, Rust), no pending translations
  • Published Apr 2017, author active
  1. Vector class
  • 5 kyu
  • Vectors of arbitrary dimensions, set of operations very similar to 1.
  • 88% with ~6k completions
  • 4 pending issues
  • 4 languages (CoffeeScript, JavaScript, Python, TypeScript), no pending translations.
  • Published Oct 2013, author inactive

Conclusion

Filling gaps

  • Move Python approved translation from 1. to 2.
  • Move Ruby approved translation from 1. to 2.
  • Move Java approved translation from 1. to 2.
@hobovsky
Copy link
Contributor Author

I think this kata is nice to exercise objects and classes in various languages, so it's good to have it, and it's good to have some variety it brings. But still, three kata might be too many.

Between 1. and 2. I think I like 2. more due to its larger scope, but it could use some technical improvements. It suffers from FP precision issues, and sometimes assertion messages are not very clear. I would vote to retire 1. and keep 2. as more interesting, potentially reporting/fixing its issues.

Between 3. and the others, I am not really sure but I think I'd vote to keep 3. It is very similar to 1. w.r.t. the set of required operations, but the arbitrary size of the vectors requires different approach. Additionally, I think this kind of tasks is a place where some repetition is good to have for learning purposes. I will not object too much though if community would decide to retire it as a duplicate of 1. or 2.

@hobovsky hobovsky moved this to Discussing in Deduplication process Aug 16, 2022
@akar-0
Copy link

akar-0 commented Aug 16, 2022

Agree with retiring 1 and conserving 2 and 3.

@Kacarott
Copy link

I agree with retiring 1 and keeping the others.

@monadius
Copy link

Retire 1.

@EloiseRosen
Copy link

don't have a strong opinion, but retiring 1 sounds fine

@hobovsky hobovsky moved this from Discussing to Filling gaps in Deduplication process Aug 23, 2022
@hobovsky
Copy link
Contributor Author

I think that conclusion is quite clear to retire 1. and keep 2., but this means that three translation have to be moved, and the kata has quite a large scope, so any help is welcome!

@awesomeAD1
Copy link

Just an updated: I've published a Python translations for 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata language/java language/python language/ruby
Projects
Status: Filling gaps
Development

No branches or pull requests

6 participants