Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate - trim string #178

Closed
4 tasks done
hobovsky opened this issue Feb 15, 2023 · 2 comments
Closed
4 tasks done

Deduplicate - trim string #178

hobovsky opened this issue Feb 15, 2023 · 2 comments
Assignees
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata

Comments

@hobovsky
Copy link
Contributor

hobovsky commented Feb 15, 2023

From wiki list

  1. Trimming a string
  • 7 kyu
  • Ellipsis contributes to the requested length. Special handling for strings with length < 4.
  • Satisfaction 85% with 2.9k completions
  • 2 pending issues
  • 5 languages + 3 pending translations
  • Published Nov 2015, author inactive.
  1. Truncate a string!
  • 7 kyu
  • Ellipsis contributes to the requested length. Special handling for strings with length < 4 (seems to be an exact duplicate of 1.)
  • Satisfaction 81% with 1.1k completions
  • No pending issues
  • 3 languages, no pending translations (all covered by 1.)
  • Published Aug 2016, author inactive.
  1. Limit string length - 1
  • 7 kyu
  • Truncate to requested length and then append ellipsis
  • Satisfaction 90% with ~7.3k completions
  • 2 pending issues
  • 5 languages, no pending translations
  • Published Aug 2013, author inactive

Conclusion

Filling gaps

  • Move C# translation from 3. to 1.
  • Move Rust translation from 3. to 1.
@hobovsky hobovsky converted this from a draft issue Feb 15, 2023
@hobovsky hobovsky added the discussion/deduplicate Discussion and vote what to do with duplicate kata label Feb 15, 2023
@hobovsky hobovsky moved this from Acknowledged to Discussing in Deduplication process Feb 15, 2023
@hobovsky
Copy link
Contributor Author

Kata 1. and 2. are exact duplicates, and kata 3. is a bit simpler w.r.t. edge cases and I think it's similar enough to get deduplicated in this group.

I think i'd keep 1. due to having more languages than the others, and retire 2. and 3.

@hobovsky hobovsky moved this from Discussing to Filling gaps in Deduplication process Feb 23, 2023
@kazk kazk removed their assignment Feb 24, 2023
@hobovsky
Copy link
Contributor Author

hobovsky commented Mar 1, 2023

Moved Rust translation.
Moved C# translation.

@hobovsky hobovsky moved this from Filling gaps to Waiting for admin actions in Deduplication process Mar 1, 2023
@kazk kazk closed this as completed Mar 7, 2023
@github-project-automation github-project-automation bot moved this from Waiting for admin actions to Done in Deduplication process Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata
Projects
Development

No branches or pull requests

2 participants