Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate - Count connected components #200

Open
hobovsky opened this issue Jul 26, 2023 · 4 comments
Open

Deduplicate - Count connected components #200

hobovsky opened this issue Jul 26, 2023 · 4 comments
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata

Comments

@hobovsky
Copy link
Contributor

hobovsky commented Jul 26, 2023

From #39

  1. Topological Image Processing: 4-Connected Components
  • 5 kyu
  • Satisfaction 85% with 113 completions
  • No pending issues
  • 3 languages + 1 pending translation (Julia and C exclusive)
  • Published Feb 2020, author active
  1. Island Count
  • 6 kyu
  • Satisfaction 95% with 224 completions
  • No pending issues
  • JS only
  • Published Oct 2015, author inactive
  1. Count the Islands
  • 6 kyu
  • 8-way neighbourhood
  • Satisfaction 96% with 446 completions
  • No pending issues
  • 3 languages, no pending translations (C++ exclusive)
  • Published Jul 2015, author inactive
@hobovsky hobovsky converted this from a draft issue Jul 26, 2023
@hobovsky hobovsky added the discussion/deduplicate Discussion and vote what to do with duplicate kata label Jul 26, 2023
@Blind4Basics
Copy link

Blind4Basics commented Jul 26, 2023

keep 1 only

  1. use test expect / no random tests / less than 5 tests

  2. nothing special against this one except the inactive author and the rank, which seems not really good...

@hobovsky hobovsky moved this from Acknowledged to Discussing in Deduplication process Jul 26, 2023
@mmccoyd
Copy link

mmccoyd commented Jul 26, 2023

  • border in the input, and input as string seems funky making it a different problem.
  • but also simplifies out of bound issues compared to 3, well it would if input was an array.
  1. getting rid of seems fine.

  • It did seem maybe under rated, so letting it lapse seems fine (at least underrated for rust with iterative lifetimes vs recursion, but that is more a rust thing)
  • 8-way adds interesting complexity if you go beyond a vanilla search. (but not if you stick to a simple solution...)
  • I've been working on a rust translation, but it can apply to whatever remains

-- logmkeys

@armeanco
Copy link

Retire: Island Count

@EloiseRosen
Copy link

vote for keep 1, retire the others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata
Projects
Status: Discussing
Development

No branches or pull requests

5 participants