Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new fields to the _STATUS.log and add run_STATUS.log #38

Open
1 of 2 tasks
veaceslavdoina opened this issue Jul 24, 2023 · 1 comment
Open
1 of 2 tasks

Add new fields to the _STATUS.log and add run_STATUS.log #38

veaceslavdoina opened this issue Jul 24, 2023 · 1 comment
Assignees

Comments

@veaceslavdoina
Copy link
Contributor

veaceslavdoina commented Jul 24, 2023

Intro

We already finished initial implementation of the _STATUS.log and it works as expected. We can see in Grafana table all information about run tests status and same logs in Kibana

Screenshot Screenshot 2023-07-21 at 12 37 11 Screenshot 2023-07-24 at 11 08 16

But from the Grafana table above it is not clear if tests run was finished and how long it take.

Also, it will be good to have information about all used components version in the logs to not search that in Dist-Tests source code.

Proposal

  • Update existing _STATUS.log and add additional fields about used components

    gethid:       docker image of the Geth used during the tests
    prometheusid: docker image of the Prometheus used during the tests
    codexcontractsethid: docker image of the codex-contracts-eth used during the tests
    
  • Add a new status log with information about the whole run - run_STATUS.log(do we need a separate file or we can append that data into existing _STATUS.log file?). It should have format similar to the _STATUS.log with some exceptions

    Category: "Finish - %Category%"                  # A special category name, which identify finish of the whole run
    Fixture: ""                                      # Empty - we don't have that information in that context
    Test Name: ""                                    # Empty - we don't have that information in that context
    Status: "%Failed%/%Skipped%/%Passed%/%Total%"    # Tests count by category
    Duration: "%Total Duration%"                     # Whole run duration
    

    We are using file name pattern and file format similar to the _STATUS.log to handle parsing and shipping by the same logs shipper rules.

    This implementation will help us to accomplish the following

    • By the end of the all tests run we will have a delimiter in the Grafana table to distinguish runs by colors
    • We will be able to see stats about duration and number of tests by runs

    And just an example of the runner output, and we would like to see that data(in a different format) in our log file

    Passed!  - Failed:     0, Passed:    26, Skipped:     2, Total:    28, Duration: 31 m 19 s - Tests.dll (net7.0)
    
@veaceslavdoina
Copy link
Contributor Author

First part was implemented during #39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants