Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature to delete workspace #378

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

Feature to delete workspace #378

wants to merge 46 commits into from

Conversation

robonetphy
Copy link
Member

@robonetphy robonetphy commented Oct 26, 2021 •
edited
Loading

resolves #342

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021 •
edited
Loading

Codecov Report

Merging #378 (8d645a1) into master (e411612) will not change coverage.
The diff coverage is n/a.

❗ Current head 8d645a1 differs from pull request most recent head 52c2658. Consider uploading reports for the commit 52c2658 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   54.70%   54.70%           
=======================================
  Files           9        9           
  Lines         117      117           
  Branches        7        7           
=======================================
  Hits           64       64           
  Misses         53       53
Impacted Files Coverage Δ
src/dataLoaders.ts 43.47% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e411612...52c2658. Read the comment docs.

@robonetphy robonetphy marked this pull request as ready for review November 4, 2021 09:48
neSpecc
neSpecc reviewed Nov 4, 2021
View reviewed changes
src/typeDefs/workspace.ts Outdated Show resolved Hide resolved
src/resolvers/workspace.js Outdated Show resolved Hide resolved
src/resolvers/workspace.js Outdated Show resolved Hide resolved
@robonetphy robonetphy requested a review from neSpecc November 14, 2021 17:24
talyguryn
talyguryn requested changes Nov 18, 2021
View reviewed changes
src/models/user.ts Outdated Show resolved Hide resolved
src/models/workspace.ts Outdated Show resolved Hide resolved
src/models/project.ts Outdated Show resolved Hide resolved
@talyguryn
Copy link
Member

but it works

talyguryn
talyguryn requested changes Dec 3, 2021
View reviewed changes
src/models/workspace.ts Outdated Show resolved Hide resolved
src/models/user.ts Outdated Show resolved Hide resolved
src/resolvers/workspace.js Outdated Show resolved Hide resolved
src/resolvers/workspace.js Show resolved Hide resolved
@robonetphy robonetphy requested a review from talyguryn December 7, 2021 18:38
ilyamore88
ilyamore88 approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@ilyamore88 ilyamore88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, pull the master branch

neSpecc
neSpecc requested changes Jan 27, 2022
View reviewed changes
src/resolvers/workspace.js Outdated Show resolved Hide resolved
src/resolvers/workspace.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc requested changes

@ilyamore88 ilyamore88 ilyamore88 approved these changes

@talyguryn talyguryn talyguryn approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ForbiddenError: You can't leave this workspace because you are the last admin
5 participants
@robonetphy @codecov-commenter @talyguryn @neSpecc @ilyamore88