Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[performance] Migrate to source-map-js #223

Open
kabachook opened this issue Jun 19, 2021 · 4 comments
Open

[performance] Migrate to source-map-js #223

kabachook opened this issue Jun 19, 2021 · 4 comments
Assignees

Comments

@kabachook
Copy link
Contributor

https://github.com/7rulnik/source-map-js
Seems to have better performance and maintained
More context: https://t.me/valya_reads_issue/111

@neSpecc
Copy link
Member

neSpecc commented Aug 4, 2021

@robonetphy Could you try benchmarking this?

@robonetphy
Copy link
Member

@neSpecc you can check this repo I have done basic time analysis of the both source-map and source-map-js library and also plot a graph

@neSpecc
Copy link
Member

neSpecc commented Aug 20, 2021

@neSpecc you can check this repo I have done basic time analysis of the both source-map and source-map-js library and also plot a graph

Thanks. Please provide your conclusions and screenshots.

@robonetphy
Copy link
Member

robonetphy commented Aug 24, 2021

@neSpecc Actually I can't conclude because you can check the time difference graph of TimeOf(source-map)-TimeOf(source-map-js) as follow. it's always varying while I am passing constant amount of work.
I am using performance.now() for time measurement. Let me know if there is better way.
newplot (5)
newplot (4)
newplot (1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants