Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define standard dimensions for margins and paddings #67

Open
AkshayCHD opened this issue May 15, 2018 · 3 comments
Open

Define standard dimensions for margins and paddings #67

AkshayCHD opened this issue May 15, 2018 · 3 comments

Comments

@AkshayCHD
Copy link

AkshayCHD commented May 15, 2018 •
edited
Loading

The dimensions and padding should be defined in dimen package in in res. So that all cards use those same designs.

Would You like to work on the issue
Yes
@AkshayCHD
Copy link
Author

@the-dagger
@championswimmer should i go on?

@4lch4
Copy link
Contributor

4lch4 commented May 18, 2018

I'll go ahead and work on this now, I'll have a PR added within the next hour or so that updates the margins and paddings to use a res reference.

@4lch4
Copy link
Contributor

4lch4 commented May 19, 2018

I got 5 of the layout files refactored and good to go but I had some things come up so I'll have to finish it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@4lch4 @AkshayCHD