Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 6.0.12 not longer compatible with PHPUnit 9 #463

Closed
alexander-schranz opened this issue Mar 26, 2023 · 1 comment · Fixed by #464
Closed

Release 6.0.12 not longer compatible with PHPUnit 9 #463

alexander-schranz opened this issue Mar 26, 2023 · 1 comment · Fixed by #464

Comments

@alexander-schranz
Copy link
Contributor

alexander-schranz commented Mar 26, 2023

With the new release of php-matcher there seems to be incompatibility added to PHPUnit 9:

PHP Fatal error:  Declaration of Coduo\PHPMatcher\PHPUnit\PHPMatcherConstraint::fail(
mixed $other, string $description, ?SebastianBergmann\Comparator\ComparisonFailure $comparisonFailure = null
): never

must be compatible with

PHPUnit\Framework\Constraint\Constraint::fail(
$other, $description, ?SebastianBergmann\Comparator\ComparisonFailure $comparisonFailure = null
): void
in /home/runner/work/SuluContentBundle/SuluContentBundle/vendor/coduo/php-matcher/src/PHPUnit/PHPMatcherConstraint.php on line 61

There should no Parameter Types added to the PHPMatcherConstraint they currently break the functionality. Only Return Types should had added to the PHPMatcherConstraint to make it compatible with PHPUnit 10.

@alexander-schranz alexander-schranz changed the title Release 6.0.12 not longer compatible Release 6.0.12 not longer compatible with PHPUnit 9 Mar 26, 2023
@oldcodefork
Copy link

@alexander-schranz I made a fork to get back PHPUnit 9 compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants