Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fsnotify to get updated on fs changes in file picker and file tree #424

Open
rcoreilly opened this issue Dec 27, 2020 · 4 comments
Labels
enhancement A new feature request needs discussion Need to discuss what to do

Comments

@rcoreilly
Copy link
Member

this appears to be the best fs event notification package for go: https://github.com/fsnotify/fsnotify -- should be pretty straightforward to plug in and get changes.

@rcoreilly
Copy link
Member Author

basically working, except that it is not safe to use on mac due to significant capacity limits -- opens a file descriptor for each monitored existing file, quickly exceeding capacity: fsnotify/fsnotify#11
there is a plan to switch to FSEvents native but not much happening at this point.

once it is working on mac too, then FileTree somehow needs to block self-generated updates to prevent duplicate updating -- basically just record path and check that.

@rcoreilly rcoreilly added the enhancement A new feature request label Dec 25, 2023
@rcoreilly
Copy link
Member Author

Still really want this -- roll up sleeves and fix fsnotify!?

@kkoreilly kkoreilly changed the title FileView, FileTree support fsnotify to get updated on fs changes Support fsnotify to get updated on fs changes in file view and file tree Feb 7, 2024
@kkoreilly kkoreilly added the needs discussion Need to discuss what to do label Feb 7, 2024
@kkoreilly
Copy link
Member

We need to resolve our plan for this at some point.

@kkoreilly kkoreilly changed the title Support fsnotify to get updated on fs changes in file view and file tree Support fsnotify to get updated on fs changes in file picker and file tree Sep 19, 2024
@kkoreilly
Copy link
Member

I disabled fsnotify on all platforms for now in #1233 since it is causing some issues; we will re-enable it once we get it all working for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature request needs discussion Need to discuss what to do
Projects
None yet
Development

No branches or pull requests

2 participants