submit an issue for toml package to reset slices instead of always adding to them (for slice fields, e.g., FavPaths)

[rcoreilly]

maybe when you change a setting? not clear.

[rcoreilly]

toml only adds to existing apparently. added a reset in SystemSettings Open method. d54055a

[kkoreilly]

Not a working solution. This removes all support for default fav paths, so, for example, I now have no fav paths.

[kkoreilly]

Given that the fav paths seem to get reset correctly after you restart the app, it doesn't seem like a toml loading problem.

[kkoreilly]

Is it possible that something is going wrong with the SetToDefaults method? Have you checked whether DefaultPaths is somehow getting modified?

[rcoreilly]

I pushed a soln: if empty after loading, set to defaults.

it is definitely just adding in toml -- I'm pretty sure I had this problem in other cases too... could do more research about that, but this should be workin gnow

[kkoreilly]

I added a unit test to tomls: it is definitely not just adding: see 288f7e9.

[rcoreilly]

it only is a problem for []struct not []string -- check out the updated test that shows the problem.

[rcoreilly]

they have different save formats -- struct is separate [[Slice]] elements and it is clear from the format that it would have a hard time knowing when to reset.

[kkoreilly]

Should we file this as an issue upstream?

[rcoreilly]

no I think it is intrinsic to the format.

[kkoreilly]

Regardless of how difficult it would be to fix, this is a violation of the standard go marshalling and umarshalling paradigm that people would expect, so there should at least be a disclaimer upstream.

[rcoreilly]

it would have to have some kind of global var during outer loop of loading to detect when the first of each such slice element was encountered, and reset then. or just reset at the start. you could google about this further though. anyway, do you want to make the test pass or should i?

[kkoreilly]

I filed the issue (pelletier/go-toml#931).

[kkoreilly]

The issue has been resolved (see pelletier/go-toml#934 and 17911aa).