Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / Question: HTTP Client and API metrics #212

Open
bsless opened this issue Apr 16, 2022 · 1 comment
Open

Feature / Question: HTTP Client and API metrics #212

bsless opened this issue Apr 16, 2022 · 1 comment

Comments

@bsless
Copy link

bsless commented Apr 16, 2022

Is there a protocol or recommendation for metrics for the API client?
Things I'd like to be able to measure:

  • Success rate and latency for different ops and endpoints
  • HTTP client metrics
  • retries

Some of this can be done by wrapping invoke or providing my own client, but regarding things like retries I'm not sure I can think of a clean way to do it.
Still, seems like it would be better if it was handled by a protocol

Thanks

@dchelimsky
Copy link
Contributor

dchelimsky commented Jun 9, 2022

You can provide a custom retry retriable? and backoff functions without wrapping invoke. See https://cognitect-labs.github.io/aws-api/cognitect.aws.client.api-api.html#cognitect.aws.client.api/client

As for a protocol, it'll be a while before we introduce anything like that given the backlog, priorities, and limited resources, but I'll certainly leave this open for consideration in the long run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants