Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dependency handling #147

Open
thompson-tomo opened this issue Apr 13, 2024 · 2 comments
Open

Improve dependency handling #147

thompson-tomo opened this issue Apr 13, 2024 · 2 comments

Comments

@thompson-tomo
Copy link

Is your feature request related to a problem? Please describe.
I want to minimise dependencies in my project by utilising framework dependencies wherever possible

Describe the solution you'd like
I want the package to not have an explicit dependency on System.Text.Json as it can be provided by the framework when targeting net 6.

Describe alternatives you've considered
Accept the additional dependency

Additional context
n/a

@dbrattli
Copy link
Contributor

dbrattli commented Apr 19, 2024

I'm not sure I understand. The package do not have an explicit depencency on System.Text.Json:

image

@dbrattli
Copy link
Contributor

Ok, I think I understand this. You want the Oryx.SystemTextJson to be built for net6 (and probably net8) without the direct dependency on System.Text.Json? Not sure how we can make it a conditional dependency based on framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants