-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support slim require #26
Conversation
…nclude partials library plugin works.
…clusion of slim plug-ins.
I see that today while I was working on this, you merge a pull request from @dmke that adds -l, and -t options. I wrote this as a generic require so that users of gulp-slim could require any ryby plug-in/library they needed to. If you would prefer to go with a more simple interface I can change this to just be a -i option instead. |
… file currently being processed (for including files in the same directory).
Hi @cognitom, to support including slim files in the same directory, I also added a |
Conflicts: test/main.coffee
I agree, this is a very welcome addition. Please consider merging. |
👍 Would be great to see this merged in! |
@bitencode @jvmccarthy @Nu-hin @phyllisstein sorry for my long absence on this repo 🙀 |
… merging back into master.
Thanks @cognitom. The merge didn't seem that bad, but now I'm running into a failing test (should include additional file with include plugin). I'll see if I can get this test fixed but have pushed it a new branch, support_slim_require_failing, in case someone else wants to look at it. Thanks for offering to make me a collaborator. Actually, we've moved on from slim to jade. In my opinion, jade is simply the templating engine to use with node.js tooling. I'll try to get this PR in but no longer use gulp-slim. |
@jvmccarthy thanks! |
…upport_slim_require Conflicts: coffee/index.coffee test/fixtures/include.slim test/main.coffee
@cognitom Ok, I've got the merge resolved. Thanks for the pointer to react.js. I've read up a bit on it and should give it a try. (Currently using angular and jade templates with webpack. Enjoying webpack so far.) |
@jvmccarthy Looks nice! Thank you. I'll merge and publish it as v0.3.0 soon. BTW, don't miss it, too. Riot.js is my favourite ;) |
Done. Thanks again @bitencode and @jvmccarthy ! |
HI @cognitom,
Here are a set of changes and a test that support using the optional plug-ins the come with slim. Specifically, I added and test the 'slim/include' plug-in that allows including common markup from multiple slim files.