Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the codeflag, code and moduleoptions to property in type SecurityDomain #59

Open
Cosaquee opened this issue Feb 8, 2016 · 0 comments

Comments

@Cosaquee
Copy link
Contributor

Cosaquee commented Feb 8, 2016

Right now the codeflag, code and moduleoptions are parameters. There is no way to change them after resource creation.

When first executed example will create resource Jboss::Securitydomain[db-auth-default]:

include jboss

jboss::securitydomain { 'db-auth-default':
  ensure        => 'present',
  code          => 'Database',
  codeflag      => 'required',
  moduleoptions => {
    'dsJndiName'        => 'java:jboss/datasources/default-db',
    'principalsQuery'   => 'select \'password\' from users u where u.login = ?',
    'hashUserPassword'  => false,
    'hashStorePassword' => false,
    'rolesQuery'        => 'select r.name, \'Roles\' from users u
join user_roles ur on ur.user_id = u.id
join roles r on r.id = ur.role_id
where u.login = ?',
  },
}

When executing next time with different parameters nothing will change but it should change:

include jboss

jboss::securitydomain { 'db-auth-default':
  ensure        => 'present',
  code          => 'Database',
  codeflag      => 'required',
  moduleoptions => {
    'dsJndiName'        => 'java:jboss/datasources/default-db2',
    'principalsQuery'   => 'select paswd from users where login = ?',
    'hashUserPassword'  => true,
    'hashStorePassword' => false,   
  },
}

We should change them to property so we can have better manage them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants