Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building lib via JitPack (Jitpack configuration file with jdk11 has to be added) #1082

Closed
carstenhag opened this issue Jan 13, 2022 · 3 comments · Fixed by #1083
Closed
Labels
enhancement New feature or request

Comments

@carstenhag
Copy link
Contributor

carstenhag commented Jan 13, 2022

Is your feature request related to a problem? Please describe.
I would like to use jitpack to build coil. Specifically, because #1072 is not merged/released yet :). Other people might want to use it to get snapshots/use master/etc.

Currently, jitpack can't build coil as jitpack's default is jdk8 and coil requires jdk11.

Jitpack build logs: https://jitpack.io/com/github/coil-kt/coil/PR1072-5a30dd96a1-1/build.log

Describe the solution you'd like
Add a jitpack.yml config file

Additional context

I think a jitpack.yml file with these contents should do the job:

jdk:
  - openjdk11
@carstenhag carstenhag added the enhancement New feature or request label Jan 13, 2022
@carstenhag
Copy link
Contributor Author

@colinrtwhite
Copy link
Member

Sounds reasonable! I'd rather not officially support Jitpack since Maven (and maven snapshots) are still the preferred way to get the Coil artifact, but it makes sense to unblock Jitpack in this case since it's an easy fix.

@carstenhag
Copy link
Contributor Author

Thanks for merging the PR :). Yeah I fully agree with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants