Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests: Graceful worker restart #135

Open
Tracked by #138
fjetter opened this issue May 25, 2022 · 2 comments
Open
Tracked by #138

Integration tests: Graceful worker restart #135

fjetter opened this issue May 25, 2022 · 2 comments
Labels
stability work related to stability test idea

Comments

@fjetter
Copy link
Member

fjetter commented May 25, 2022

Graceful worker restart

Can we run a workload where workers are calling close_gracefully every minute? Can we successfully shift data from the dying to the living?

Let's try transforming a sizeable parquet dataset while also setting the worker's lifetime to something like one minute with restarts

@fjetter fjetter added the stability work related to stability label May 25, 2022
@crusaderky
Copy link
Contributor

crusaderky commented Jul 7, 2022

Strongly related:

We could scale test_RetireWorker_stress up to production size:

https://github.com/dask/distributed/blob/f7f650154fea29978906c65dd0225415da56ed11/distributed/tests/test_active_memory_manager.py#L1079-L1085
https://github.com/dask/distributed/blob/f7f650154fea29978906c65dd0225415da56ed11/distributed/tests/test_active_memory_manager.py#L1133-L1175

The integration test must replicate both use cases of the unit test above, with and without ReduceReplicas running alongside RetireWorker, as the two policies heavily interact with each other.

@crusaderky
Copy link
Contributor

DOD / AC

This story is done when the integration test portrays the behaviour of distributed on coiled as described above.
If it demonstrates a flaw, remediation of the flaw is out of scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stability work related to stability test idea
Projects
None yet
Development

No branches or pull requests

3 participants