Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests: GIL #137

Open
Tracked by #138
fjetter opened this issue May 25, 2022 · 2 comments
Open
Tracked by #138

Integration tests: GIL #137

fjetter opened this issue May 25, 2022 · 2 comments
Labels
stability work related to stability test idea

Comments

@fjetter
Copy link
Member

fjetter commented May 25, 2022

  • What happens if workers frequently run functions that hold the GIL
  • Are our default configurations configured robust to survive 1s, 5s, 30s, 5min GIL holding?
  • Is Coiled relying on the GIL to be released at least every Xs?
  • What happens if the worker repeatedly locks up?
  • Can we define sane default configurations to make everything a bit more robust? [n.d. @crusaderky : this is follow-up remediation work]

xref dask/distributed#6282

@fjetter fjetter added the stability work related to stability label May 25, 2022
@crusaderky
Copy link
Contributor

crusaderky commented Jul 7, 2022

In scope

Push the envelope until everything breaks.
Document where it breaks.
Understand if it's a reasonable limitation or if we want to pen in remediation work.

Two use cases:

  • a sync task does not release the GIL because it's stuck in C space
  • a sync task does not release the GIL because it's running pure Python bytecode

Out of scope

@gjoseph92
Copy link
Contributor

The graph we're running should involve worker<->worker communication. If it's just client.map(gil_func, range(100_000), I wouldn't expect as much to happen. The problems arise especially when the worker event loop has many other things to do while the GIL is also held.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stability work related to stability test idea
Projects
None yet
Development

No branches or pull requests

4 participants