Bug report: The Flipper's private variable nV and nC is not copied in the copy function

[clw-ponyai]

When assignment a QProblem to replace another existing one, the Flipper will also be copied:

qpOASES/src/QProblemB.cpp

Line 1167 in 326a651

flipper = rhs.flipper;

But the Flipper's private variable nV and nC is not copied in the copy function, the old value is kept:

qpOASES/src/Flipper.cpp

Line 241 in 326a651

return set( &(rhs.bounds),rhs.R, &(rhs.constraints),rhs.Q,rhs.T );

This may leads to buffer overflow. If the old_nV > new_nV, the memcpy will overrun the buffer.

qpOASES/src/Flipper.cpp

Line 180 in 326a651

memcpy( R,_R, nV*nV*sizeof(real_t) );

My quick fix for this:

diff -urN a/src/Flipper.cpp b/src/Flipper.cpp
--- a/src/Flipper.cpp	2017-04-03 12:20:42.000000000 +0800
+++ b/src/Flipper.cpp	2020-06-28 12:01:42.438327284 +0800
@@ -238,6 +238,8 @@
 returnValue Flipper::copy(	const Flipper& rhs
 							)
 {
+	nV = rhs.nV;
+	nC = rhs.nC;
 	return set( &(rhs.bounds),rhs.R, &(rhs.constraints),rhs.Q,rhs.T );
 }